Repository navigation
test: [SDK-5338] stub _delayedInit in the consent tests so init does not outlive the environment - #1508
Merged
Conversation
… the environment The "Consent Required" block calls setConsentGiven(true) without an await. _pendingInit defaults to true, so the call starts the full init chain. When the environment tears down first, the chain reaches document.visibilityState in init.ts and Vitest reports an unhandled rejection with all tests green.
fadi-george
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Stub
OneSignal._delayedInitin the "Consent Required" tests so an un-awaited init chain cannot outlive the test environment.Details
CI run 35790346377 on #1505 failed with all 759 tests green and 1 unhandled rejection:
A second run on the same commit passed. The same error also failed run 35666490541 on
sherwin/sdk-5229, so the flake predates the M3 stack.Cause. The "Consent Required" block calls
void OneSignal.setConsentGiven(true).OneSignal._pendingInitdefaults totrue, so the call starts_delayedInit()and the full init chain. The test does not await the chain. When Vitest tears down the DOM environment first, the chain reachesdocument.visibilityStatewith nodocument.Fix. Stub
_delayedInitin the block'sbeforeEach. The 2 tests check only the consent gate onloginandlogout, not init. A// @ts-expect-errormarks the private member, the same pattern the file already uses.Scope. Test-only. No SDK code changes. Run 35648657769 on
sherwin/sdk-5230failed the same way withlocalStorage is not definedfromLoginManager.test.ts. That leak is noted on SDK-5338 and is not part of this PR.Systems Affected
Validation
Tests
Info
vp check: 0 errorsnpx tsc --noEmit: cleanvp test run: 67 files, 684 tests pass, 0 unhandled errorsChecklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Not needed. Test-only change.
Checklist
Related Tickets
SDK-5338