Conversation
sabhi128
requested review from
hiveer,
ice201508,
jialudev,
ymh6315431,
yoiteyou and
zhendi
as code owners
September 17, 2026 13:55
There was a problem hiding this comment.
🟡 Changes recommended
The normal model-summary flow does not map PyTorch or ONNX tags to these framework values, so the new branch is unreachable.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds PyTorch and ONNX metadata badges and unit tests covering supported model formats.
Changes:
- Renders parameter and architecture badges for PyTorch and ONNX.
- Adds tests for Safetensors, GGUF, PyTorch, and ONNX.
File summaries
| File | Description |
|---|---|
frontend/src/components/models/ModelMetadata.vue |
Adds PyTorch/ONNX badge rendering. |
frontend/src/components/__tests__/models/ModelMetadata.spec.js |
Adds framework rendering tests. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR expands
ModelMetadata.vueto display model parameters and architecture badges for PyTorch and ONNX model formats, and adds comprehensive unit test coverage.Key Enhancements:
ModelMetadata.vuenow rendersmodel_paramsandarchitecturebadges whenframeworkisPyTorchorONNX, ensuring full parity withSafetensorsandGGUF.frontend/src/components/__tests__/models/ModelMetadata.spec.jscovering rendering behavior acrossSafetensors,GGUF,PyTorch, andONNX.