Repository navigation
Ignore bare-metal in deny.toml - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new RustSec advisory ignore to keep cargo deny check advisories passing for this embedded firmware repo while upstream dependencies migrate off a deprecated crate.
Changes:
- Ignore
RUSTSEC-2026-0110(bare-metal deprecation/archive) indeny.tomlwith an explanatory reason.
jerrysxie
approved these changes
Apr 30, 2026
williampMSFT
approved these changes
Apr 30, 2026
dymk
added a commit
to dymk/odp-embedded-controller
that referenced
this pull request
May 28, 2026
embedded-services PR OpenDevicePartnership#11 (currently dymk/odp-canonical-wire-and-odp-client @ b00c3a7) deleted embedded_services::relay::mctp::impl_odp_mctp_relay_handler! and replaced it with odp_client::impl_odp_relay_handler! in a new odp-client crate. This commit migrates platform-common to the new path and re-pins all embedded-services-sourced deps (direct and transitive) through Cargo [patch] sections so this PR can ship to the personal fork before PR OpenDevicePartnership#11 merges upstream. Files: - platform/platform-common/Cargo.toml: add odp-client direct dep - platform/platform-common/src/lib.rs: swap macro path embedded_services::relay::mctp::impl_odp_mctp_relay_handler! -> odp_client::impl_odp_relay_handler! (macro grammar unchanged — argument list is identical) - platform/{platform-common,dev-qemu,dev-imxrt,dev-npcx,dev-mcxa,dev-mec}/Cargo.toml: add identical [patch."https://github.com/OpenDevicePartnership/embedded-services"] block re-routing 14 embedded-services workspace crates to the dymk fork rev b00c3a7. REVERT THIS BLOCK once PR OpenDevicePartnership#11 merges to upstream. - platform/*/Cargo.lock: updated to resolve from the dymk fork rev Gates (all 5 CI-matrix platforms pass cargo clippy --locked + fmt --check; dev-qemu also passes cargo build --locked for riscv32imac-unknown-none-elf): - platform-common / dev-qemu / dev-imxrt / dev-npcx / dev-mcxa: clippy clean - dev-qemu binary: 6.3 MB ELF produced A pre-existing clippy::clone_on_copy finding in platform-common/src/mock/battery.rs:35 is gated behind --all-features --all-targets which is NOT part of CI scope (CI runs default-features clippy per platform). Reproduces unchanged on origin/main; out of scope for this PR.
dymk
added a commit
to dymk/odp-embedded-controller
that referenced
this pull request
May 28, 2026
embedded-services PR OpenDevicePartnership#11 (currently dymk/odp-canonical-wire-and-odp-client @ b00c3a7) deleted embedded_services::relay::mctp::impl_odp_mctp_relay_handler! and replaced it with odp_client::impl_odp_relay_handler! in a new odp-client crate. This commit migrates platform-common to the new path and re-pins all embedded-services-sourced deps (direct and transitive) through Cargo [patch] sections so this PR can ship to the personal fork before PR OpenDevicePartnership#11 merges upstream. Files: - platform/platform-common/Cargo.toml: add odp-client direct dep - platform/platform-common/src/lib.rs: swap macro path embedded_services::relay::mctp::impl_odp_mctp_relay_handler! -> odp_client::impl_odp_relay_handler! (macro grammar unchanged — argument list is identical) - platform/{platform-common,dev-qemu,dev-imxrt,dev-npcx,dev-mcxa,dev-mec}/Cargo.toml: add identical [patch."https://github.com/OpenDevicePartnership/embedded-services"] block re-routing 14 embedded-services workspace crates to the dymk fork rev b00c3a7. REVERT THIS BLOCK once PR OpenDevicePartnership#11 merges to upstream. - platform/*/Cargo.lock: updated to resolve from the dymk fork rev Gates (all 5 CI-matrix platforms pass cargo clippy --locked + fmt --check; dev-qemu also passes cargo build --locked for riscv32imac-unknown-none-elf): - platform-common / dev-qemu / dev-imxrt / dev-npcx / dev-mcxa: clippy clean - dev-qemu binary: 6.3 MB ELF produced A pre-existing clippy::clone_on_copy finding in platform-common/src/mock/battery.rs:35 is gated behind --all-features --all-targets which is NOT part of CI scope (CI runs default-features clippy per platform). Reproduces unchanged on origin/main; out of scope for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: OpenDevicePartnership/embedded-services#817
We are experiencing the same issue here.