Feat/001 markdown schema roundtrip - #5
Merged
Conversation
…actory Add createMarkdownExtensions in src/lib as the single source of TipTap extension configuration for MarkdownEditor and MarkdownView. Remove the StarterKit trimming so headings, lists, task lists, blockquotes, code blocks and horizontal rules survive round-trips instead of being silently dropped. Task lists render but cannot be created (shortcut and input rule stripped); underline stays disabled since Markdown cannot express it. Configure link through StarterKit and drop the duplicate @tiptap/extension-link dependency; promote @tiptap/extension-list to a declared dependency. Refs spec 001-markdown-schema-roundtrip
Instantiate a real Editor from createMarkdownExtensions and assert the serialized Markdown for task lists, bullet/ordered lists, headings, blockquotes, code blocks, horizontal rules, nested lists, inline marks, mixed lists, empty and plain content. Also fix task lists serializing as loose lists by giving TaskList a tight attribute, and verify underline is absent from the schema. Refs spec 001-markdown-schema-roundtrip
Replace the mock-everything component tests with real TipTap editors: - MarkdownEditor no longer corrupts content on open, reports the full document (task list intact) on edit, and replaces the document on an external value change; toolbar still offers exactly Bold/Italic/ Strikethrough/Link plus Unlink inside a link. - Task list creation stays closed: Mod-Shift-9 and the '[ ] ' input rule do nothing (guarded against a default TaskItem that would create one), while Enter split and Shift-Tab lift still work inside a list. - MarkdownView renders structure, task lists as checkboxes reflecting state, ignores checkbox clicks, and suppresses the prose bullet. Refs spec 001-markdown-schema-roundtrip
Document the behavioral change (MarkdownEditor no longer corrupts stored Markdown on open; MarkdownView now renders full structure) as an agent-executable upgrade prompt, and add MarkdownEditor/MarkdownView to the README component list. Mark all implementation steps complete. Refs spec 001-markdown-schema-roundtrip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the Markdown editing and rendering components to fully support all Markdown constructs, preventing data loss and improving structural rendering. The changes include dependency updates, a new shared extension factory, comprehensive tests, and updated documentation to guide consumers through the behavioral improvements. There are no breaking API changes, but the rendering of Markdown is now much more faithful.