Skip to content

fix(rog-aura): add logo power zone for G615LR - #347

Merged
Ghoul4500 merged 1 commit into
OpenGamingCollective:mainfrom
Airzh1124:fix/g615lr-logo
Aug 28, 2026
Merged

fix(rog-aura): add logo power zone for G615LR#347
Ghoul4500 merged 1 commit into
OpenGamingCollective:mainfrom
Airzh1124:fix/g615lr-logo

Conversation

@Airzh1124

Copy link
Copy Markdown
Contributor

Description

Declare the existing Logo power zone for the G615LR Aura configuration.

The G615LR lid logo uses the already implemented Logo protocol bits, but the model support entry only exposed Keyboard and Lightbar. No protocol changes are required.

Tested Hardware & Environment

  • ASUS Laptop Model: ROG Strix G16 G615LR_G615LR
  • Board Name: G615LR
  • Aura USB Controller: 0b05:19b6
  • Linux Distribution: NixOS 26.11 (Zokor)
  • Kernel Version: 7.2.0
  • asusctl Version: 6.4.0

Hardware verification

  • Confirmed Supported Aura Power Zones changed from Keyboard, Lightbar to Keyboard, Lightbar, Logo.
  • Confirmed asusctl aura power logo --awake enables the lid logo.
  • Confirmed the logo follows the global Aura effect by setting the static colour to red.
  • Confirmed the Lightbar remains independently disabled while the Logo is enabled.

AI disclosure

AI assistance was used to trace the existing PowerZones::Logo implementation and prepare the initial diagnosis. I reviewed the one-line change, built it locally, and personally performed the hardware verification described above.

Verification and testing

  • I have performed a self-review of my code
  • Comments are not applicable because this is a one-line support-data change
  • Documentation changes are not required for this model capability correction
  • cargo fmt --all -- --check
  • cargo check --all-targets
  • cargo test --all
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo cranky

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 324e8d78-f5cc-4b50-aef1-f39ad6444dbd

📥 Commits

Reviewing files that changed from the base of the PR and between c1640ca and 99b74a2.

📒 Files selected for processing (1)
  • rog-aura/data/aura_support.ron

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📜 Recent review details
🔇 Additional comments (1)
rog-aura/data/aura_support.ron (1)

504-504: LGTM!


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Added logo lighting support for the G615LR device, alongside existing keyboard and lightbar lighting zones.

Walkthrough

The G615LR configuration now exposes the Logo as a controllable power zone alongside the Keyboard and Lightbar.

Changes

G615LR Power Zone

Layer / File(s) Summary
Configure G615LR Logo zone
rog-aura/data/aura_support.ron
The G615LR power_zones list now includes Logo.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 99b74

This localized change exposes the existing lid Logo control for the G615LR without altering protocol behavior; normal checks and hardware verification are complete, and no actionable merge-blocking risk remains.

Suggested labels: rog-aura, fix

Suggested reviewers: scardracs, ghoul4500, deminearchiver

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding the Logo power zone for the G615LR Aura configuration.
Description check ✅ Passed The description explains the change, tested hardware and environment, hardware verification, AI disclosure, and completed verification checks. The issue reference is not populated, but this is non-cri…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change, tested hardware and environment, hardware verification, AI disclosure, and completed verification checks. The issue reference is not populated, but this is non-critical because the change and validation details are complete.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added fix Fix a bug or an issue rog-aura Keyboard / Aura RGB labels Aug 28, 2026

@Ghoul4500 Ghoul4500 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@Ghoul4500
Ghoul4500 merged commit 47a02fb into OpenGamingCollective:main Aug 28, 2026
3 checks passed
@Airzh1124
Airzh1124 deleted the fix/g615lr-logo branch August 28, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fix a bug or an issue rog-aura Keyboard / Aura RGB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants