Entrypoint escaping was breaking passwords with control characters for sed#8
Open
jonbartels wants to merge 3 commits into
Open
Entrypoint escaping was breaking passwords with control characters for sed#8jonbartels wants to merge 3 commits into
jonbartels wants to merge 3 commits into
Conversation
…oint to update the application properties file. This handling was not correctly escaping the strings and interactions with sed and control characters for sed were breaking deployments with complex passwords. This introduces a function to DRY up the code and uses awk instead of sed to avoid control character issues. Signed-off-by: Jon Bartels <jonathan.bartels@gmail.com>
kryskool
approved these changes
Jul 12, 2026
kpalang
requested review from
a team,
NicoPiel,
gibson9583,
kayyagari,
mgaffigan,
ssrowe and
tonygermano
and removed request for
a team
July 14, 2026 18:38
tonygermano
requested changes
Jul 24, 2026
| set -e | ||
|
|
||
| APP_DIR=/opt/engine | ||
| APP_DIR=/opt/oie |
Member
There was a problem hiding this comment.
question: is this supposed to change?
There was no reference to it in the commit messages. Probably should be a separate commit if intentional.
Comment on lines
-12
to
-18
| custom_extension_count=`ls -1 "$APP_DIR"/custom-extensions/*.zip 2>/dev/null | wc -l` | ||
| if [ $custom_extension_count != 0 ]; then | ||
| echo "Found ${custom_extension_count} custom extensions." | ||
| for extension in $(ls -1 "$APP_DIR"/custom-extensions/*.zip); do | ||
| unzip -o -q $extension -d "$APP_DIR/extensions" | ||
| done | ||
| fi |
Member
There was a problem hiding this comment.
question: was this section intentionally deleted?
It doesn't look like it was moved elsewhere in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passwords are read from env vars, they are handled by the entrypoint to update the application properties file. This handling was not correctly escaping the strings and interactions with sed and control characters for sed were breaking deployments with complex passwords.
This introduces a function to DRY up the code and uses awk instead of sed to avoid control character issues.
I do get warnings
awk: warning: escape sequence.' treated as plain.'- Should I fix these?I also think this might still have issues with
#. If a string with#is copied into the properties file without quoting then it may be treated as a comment.