Repository navigation
fix(deps): use published @openmouse/protocol 0.48.1 instead of git snapshot - #29
TristanSibug wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Use the published protocol package package.json |
The @openmouse/protocol dependency now uses version range ^0.48.1 instead of a GitHub repository URL. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested reviewers: snekxs
Merge Risk: 
263fb
-
The dependency update is ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names the change: the desktop app's @openmouse/protocoldependency moves from a Git snapshot to the published 0.48.1 release. The raw summary confirms that package.json now points to ^0.48.1…Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the change: the desktop app's
@openmouse/protocoldependency moves from a Git snapshot to the published 0.48.1 release. The raw summary confirms that package.json now points to ^0.48.1 instead of the GitHub URL, and the objectives describe the same switch. The title is short and specific, and it uses the conventional fix(deps) prefix. It does not mention the driver-detection result, but the title does not need to cover every detail.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Changes are confined to ignored paths and reportedly align the desktop protocol dependency with published version 0.48.1. The author reports successful device detection testing on Windows; no material concern was supplied. Notes:
You can add or adjust custom eligibility rules. Learn more. |
The desktop app installed @openmouse/protocol from a git snapshot (0.1.0, locked to commit f780d0d), while the web app uses the published 0.48.1. The snapshot has far fewer drivers, and its Pulsar driver fails the whole status read if the mouse does not answer the firmware-version query.
This pins the desktop app to 0.48.1, the same version as the web app, in package.json and package-lock.json.
Tested: Windows, Rakk Gahum (detected through the Pulsar driver). Before this change the mouse was not identified in the desktop app; after it, it is.
Note
Replace git snapshot of
@openmouse/protocolwith published 0.48.1Changes the
@openmouse/protocoldependency in package.json from a GitHub repository URL to the semver range^0.48.1, and updates package-lock.json to match.Macroscope summarized 263fb7f.
Summary by CodeRabbit