Repository navigation
Conversation
Add the Launcher config rows for G6 HE (0xd0a2), G3 HE (0xd0a3) and JamesDonkey RSR7 Ultra+ (0xd085), and list LM7 Air (0x2801) with the 8K Nordic mice. Taken from Launcher's per-model configs; not confirmed on hardware.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Add mouse registry entries src/keychron/index.ts |
The Launcher list gains entries for G6 HE 8K, G3 HE, and JamesDonkey RSR7 Ultra+, including their settings and button mappings. The 8K Nordic list gains the Keychron LM7 Air product ID. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Feature
Suggested reviewers: ydw1904
Merge Risk: 
Minimal · up to e51d6
-
The change adds four mouse registry entries. No actionable merge-blocking issue is established, although hardware compatibility remains unconfirmed.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds four mouse product IDs with capability metadata and existing protocol routing. Effects are confined to the listed models, with no changes to shared protocol implementations. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Summary
Diffed Keychron Launcher's per-model definitions (launcher.keychron.com, PIDs under VID 0x3434) against this repo. Four product ids were missing:
0xd0a2Keychron G6 HE and0xd0a3Keychron G3 HE: new Launcher config rows (same shape as the existing G6 HE0xd09d).0xd085JamesDonkey RSR7 Ultra+: new config row.0x2801Keychron LM7 Air: listed with the 8K Nordic mice, as Launcher flags it8k_nordic.Left alone
0xd030is "Lemokey G2" in Launcher but a Link receiver here;0xd06a(Nape) and0xff04(GM32) lack enough data. These need a decision or a device.Notes
Taken from Launcher configs; not confirmed on hardware. Local
npx tsx --testof this branch passes exceptnape-hid.test.ts, which fails identically on untouchedorigin/mainhere because the worktree has no builtdist/.Note
Add Keychron G6 HE, G3 HE, RSR7 Ultra+ and LM7 Air mouse product IDs
KEYCHRON_LAUNCHER_MICEin index.ts, with DPI ranges, polling rates, lift-off settings and button mappingsKEYCHRON_8K_NORDIC_MICEcatalog, so it uses the 8K Nordic protocolMacroscope summarized e51d6b3.
Summary by CodeRabbit