openrc-run: fix memory leaks in PID setup and dependency handling - #1057
Merged
Conversation
setenv() copies its input, so free the temporary PID string after setting RC_OPENRC_PID and RC_RUNSCRIPT_PID. Also free the reexport list after importing dependency variables. load_dep_env() similarly leaked its dependency list because it mistakenly freed the unrelated global services list instead. These leaks were reported by LeakSanitizer during service execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setenv() copies its input, so free the temporary PID string after setting RC_OPENRC_PID and RC_RUNSCRIPT_PID.
Also free the reexport list after importing dependency variables. load_dep_env() similarly leaked its dependency list because it mistakenly freed the unrelated global services list instead.
These leaks were reported by LeakSanitizer during service execution.