Fix on_frame_cb-only publish/play/SO authorization bypass - #244
Draft
cursor[bot] wants to merge 1 commit into
Draft
Fix on_frame_cb-only publish/play/SO authorization bypass#244cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
When a server registered only on_frame_cb (a common frame-observation pattern), publish and play commands were accepted without on_publish_cb or on_play_cb, and AMF3 shared objects reached on_shared_object_cb without on_shared_object_auth_cb. Extend the same cross-callback guards already used for on_media_cb. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open PR with on_frame_cb authorization bypass fix