Add reusable SonarQube scan workflow - #115
Merged
Merged
Conversation
TagsThe following tags will be created on main after merge 🏷️ |
✅ Semgrep Security Scan Passed🎉 No security issues found! View run |
There was a problem hiding this comment.
🟡 Changes recommended
Add SonarQube server URL support or requirements and reconcile the repository workflow guidance.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a reusable, versioned SonarQube workflow with pinned actions, configurable refs, documentation, changelog updates, and dependency refreshes.
Changes:
- Adds the SonarQube workflow and usage documentation.
- Documents deprecated action consumers.
- Refreshes npm dependencies and release metadata.
File summaries
| File | Summary |
|---|---|
tf-plan/README.md |
Documents deprecated action consumers. |
tf-plan-comment/README.md |
Documents deprecated action consumers. |
tf-apply/README.md |
Documents consumer status. |
semgrep/README.md |
Updates deprecation and consumer details. |
select-branch-workspace/README.md |
Documents deprecated action consumers. |
package-lock.json |
Refreshes transitive dependencies. |
deploy/README.md |
Documents deprecated action consumers. |
cleanup/README.md |
Documents deprecated action consumers. |
build/README.md |
Documents deprecated action consumers. |
build-publish/README.md |
Documents deprecated action consumers. |
build-apply/README.md |
Documents deprecated action consumers. |
.gitignore |
Adjusts ignore rules. |
.github/workflows/run_sonar_scan.yml |
Adds the reusable SonarQube workflow; SONAR_HOST_URL still needs to be supported or explicitly required. |
.github/workflows/READMES/run_sonar_scan.md |
Documents workflow usage; server URL requirements need clarification. |
.github/workflows/CHANGELOGS/run_sonar_scan.md |
Adds the initial 1.0.0 changelog; repository-level workflow guidance is inconsistent. |
Review details
Suppressed comments (2)
.github/workflows/CHANGELOGS/run_sonar_scan.md:5
- This release makes reusable workflows broader than Terraform and introduces a versioned workflow, but the top-level
README.md:82-88still says reusable workflows are Terraform-only, unversioned, and should uselegacy-stable. Please update that repository guidance in this change so consumers are not given a contradictory migration/versioning policy.
## 1.0.0
.github/workflows/READMES/run_sonar_scan.md:36
- The documented contract lists only
SONAR_TOKEN, but a generic SonarQube Server scan also needs the target server URL. Without documenting and forwardingSONAR_HOST_URL(or explicitly requiringsonar.host.urlin the caller's configuration), consumers with a non-default server cannot follow this usage successfully.
## Secrets
| Secret | Required | Description |
| ------------- | -------- | ---------------------------------------------- |
| `SONAR_TOKEN` | Yes | Token used to authenticate the SonarQube scan. |
- Files reviewed: 13/15 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+32
to
+33
| env: | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Jira: N/A
Description of Changes
Versioning
Dependencies of PR
None.
Testing