Change "change your own delegation" option to account button by Borreg0 · Pull Request #6141 · OpenSlides/openslides-client

Borreg0 · 2026-04-30T15:15:40Z

closes #5967

…-menu

…e delegation

bspekker

Changing the own delegation doesn't work anymore for users with only "can change own delegation" permission:

The dialogue I can open from the user menu looks good, but the dialogue you can open in the participant list as admins by clicking on the column with groups, numbers, structure levels etc, should still be the old previous dialogue:

The column I mean:

The dialogue that should still be available as is for everyone with more admin permissions than just "can change own delegation":

…-menu

Elblinator · 2026-07-29T07:11:49Z

        this.router.navigate([userId, `edit`], { relativeTo: this.route });
    }
 }
+export { areGroupsDiminished };


remove bc it's unused
and such export should also be below the imports but above the main component/director/service

…-menu

Elblinator

Additionally the wrong Id is used to select the delegations
Reproduction:

in the default (dev) setup
create a second meeting
in the new meeting add 'a' as participant
in the settings activate the delegations
try to delegate from admin to a (or vidse versa)
Error is thrown:

 Error: User(s) [2] delegation ids don't belong to meeting 2.

Elblinator · 2026-08-03T11:27:34Z

-                    } @else if (hasActiveMeeting) {
-                        @if (isPresent) {
+                    @if (hasActiveMeeting) {
+                        @if (isAllowedSelfSetPresent && hasActiveMeeting) {


Suggested change

@if (isAllowedSelfSetPresent && hasActiveMeeting) {

@if (isAllowedSelfSetPresent) {

Elblinator · 2026-08-03T11:28:26Z

                            </div>
                        }
                    }
+                    @if (isVoteDelegationEnabled && canEditOwnDelegation()) {


Also needs to be in "hasActiveMeeting"

Elblinator · 2026-08-03T11:58:22Z

        @Inject(MAT_DIALOG_DATA) public readonly infoDialog: InfoDialog,
-        private participantRepo: ParticipantControllerService,
+        protected participantRepo: ParticipantControllerService,
        private userSortService: ParticipantListSortService,
        private groupRepo: GroupControllerService,
-        private structureLevelRepo: StructureLevelControllerService,
+        protected structureLevelRepo: StructureLevelRepositoryService,
+        private activeMeetingIdService: ActiveMeetingIdService,
        private meetingSettings: MeetingSettingsService,
        private operator: OperatorService


also move to injects

And sort public above, then protected, then private

Elblinator · 2026-08-03T12:07:28Z

            isHidden: !canSeeItemMenu() && viewport.isMobileSubject
        "
        class="cell-slot"
+        [hidden]="!hasOptions()"


canSeeItemMenu should be adjusted not [hidden] added

Elblinator · 2026-08-03T12:11:10Z

+export function afterDialogClosed(
+    dialogRef: MatDialogRef<ParticipantListInfoDialogComponent, InfoDialog>,
+    user: ViewUser,
+    operator: OperatorInfo,


rename. Operator is always the operator, do not use "operator"

Elblinator · 2026-08-03T13:52:22Z

        return this.user.short_name + ': ' + stringForUserPresent;
    }
+
+    public canEditOwnDelegation(): boolean {


Can edit OWN delegation:
this.operator.hasPerms(Permission.userCanEditOwnDelegation) &&
this.activeMeeting.meeting.user_ids.includes(this.operator.operatorId)
is enough

Elblinator · 2026-08-04T07:21:36Z

+            changeOwnDel: this.operator.hasPerms(Permission.userCanEditOwnDelegation),
+            canUpdate: this.operator.hasPerms(Permission.userCanUpdate)
+        };
+        afterDialogClosed(dialogRef, user, operatorInfo, this.activeMeeting.meeting, this.participantRepo, this.prompt);


add afterDialogClosed as a function in this.infoDialog
subsequent changes for all afterDialogClosed bc they will be called diifferently

Elblinator · 2026-08-04T07:28:28Z

    }
 }
+
+export function areGroupsDiminished(oldGroupIds: number[], newGroupIds: number[], activeMeeting: ViewMeeting): boolean {


also move into ParticipantListInfoDialogService and subsequent change the call of this function everywhere

Elblinator · 2026-08-04T09:21:04Z

+            if (!result.group_ids?.length) {
+                result.group_ids = [this.activeMeeting!.default_group_id];
+            }
+            if (result.vote_delegated_to_id === 0) {


Suggested change

if (result.vote_delegated_to_id === 0) {

if (result.vote_delegated_to_id?.length === 0) {

do You mean this?
The id should never even try to be set to zero

Elblinator · 2026-08-04T09:33:02Z

+    );
+}
+
+export function afterDialogClosed(


Either move this function into the operator and let also the participant-list use it (more work and I would not recommmendt this actually)
Or do not export this function implement the function per component.

If possible remove the OperatorInfo (including the interface)

…-menu

Borreg0 · 2026-08-06T14:38:35Z

Additionally the wrong Id is used to select the delegations Reproduction:

1. in the default (dev) setup

2. create a second meeting

3. in the new meeting add 'a' as participant

4. in the settings activate the delegations

5. try to delegate from admin to a (or vidse versa)

6. Error is thrown:

 Error: User(s) [2] delegation ids don't belong to meeting 2.

I can reproduce it.

Furthermore, I found that if a new participant is created and the user tries to delegate the vote to him, a new error appears. I have been working on this but I cannot find the cause yet.

How to reproduce:

In the second meeting, create a new participant
In the settings activate the delegations
Try to delegate from admin to the new participant (or viceversa)
Error is thrown

Error: Model 'meeting_user/26' does not exist.

…-menu

Add option to account button

17a5742

Borreg0 self-assigned this May 4, 2026

Javier Borrego added 2 commits May 4, 2026 17:30

Permissions updated and advances in data display

3e3d1df

Merge remote-tracking branch 'origin' into 5967-change-own-delegation…

d19ff28

…-menu

Borreg0 mentioned this pull request May 5, 2026

Improve "change your own delegation" menu #5967

Open

6 tasks

Javier Borrego added 2 commits May 6, 2026 11:44

Removed current user from selectable, update user data, able to remov…

b0d7c97

…e delegation

Added helptext

ca26d29

Borreg0 marked this pull request as ready for review May 6, 2026 12:17

Borreg0 requested review from Elblinator and bspekker May 6, 2026 12:17

Borreg0 assigned bspekker and Elblinator and unassigned Borreg0 May 6, 2026

Borreg0 added feature Schrödinger projectname labels May 6, 2026

bspekker requested changes May 7, 2026

View reviewed changes

bspekker assigned Borreg0 and unassigned bspekker and Elblinator May 7, 2026

Javier Borrego added 5 commits July 27, 2026 09:44

Angular 22

aec54ab

Solve conflicts

9ecebc0

Merge remote-tracking branch 'origin' into 5967-change-own-delegation…

cf544c5

…-menu

Merge remote-tracking branch 'origin' into 5967-change-own-delegation…

ff7543b

…-menu

Fixed permissions and restablished dialog fields

77edf34

Borreg0 assigned bspekker and Elblinator Jul 28, 2026

Borreg0 requested a review from bspekker July 28, 2026 13:44

Borreg0 removed their assignment Jul 28, 2026

Elblinator requested changes Jul 29, 2026

View reviewed changes

Elblinator assigned Borreg0 Jul 29, 2026

Elblinator unassigned bspekker and Elblinator Jul 29, 2026

Javier Borrego added 3 commits July 31, 2026 13:15

Merge remote-tracking branch 'origin' into 5967-change-own-delegation…

6df3696

…-menu

Merge remote-tracking branch 'origin' into 5967-change-own-delegation…

b88cec4

…-menu

Code cleanup and improved logic

b815f63

Borreg0 requested a review from Elblinator August 3, 2026 08:03

Borreg0 assigned bspekker and Elblinator and unassigned Borreg0 Aug 3, 2026

Elblinator requested changes Aug 4, 2026

View reviewed changes

Elblinator assigned Borreg0 and unassigned bspekker and Elblinator Aug 4, 2026

Javier Borrego added 2 commits August 5, 2026 09:06

Merge remote-tracking branch 'origin' into 5967-change-own-delegation…

e72488f

…-menu

Minor bugs fixed, refactor and cleanup

4f55913

Borreg0 marked this pull request as draft August 5, 2026 14:43

Javier Borrego added 3 commits August 28, 2026 13:26

Solved merging conflicts

927b2a6

Merge remote-tracking branch 'origin' into 5967-change-own-delegation…

6e8a679

…-menu

Fix vote delegation on new participants in new meeting

f5a6d8c

Borreg0 marked this pull request as ready for review August 31, 2026 14:12

Borreg0 requested a review from Elblinator August 31, 2026 14:12

Borreg0 assigned bspekker and Elblinator and unassigned Borreg0 Aug 31, 2026

	@if (isAllowedSelfSetPresent && hasActiveMeeting) {
	@if (isAllowedSelfSetPresent) {

	if (result.vote_delegated_to_id === 0) {
	if (result.vote_delegated_to_id?.length === 0) {

Uh oh!

Conversation

Borreg0 commented Apr 30, 2026

Uh oh!

bspekker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Elblinator left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Elblinator Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Borreg0 commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Elblinator Aug 3, 2026 •

edited

Loading

Borreg0 commented Aug 6, 2026 •

edited

Loading