Fix change recommendation nr while creating - #6459
Open
Elblinator wants to merge 2 commits into
Open
Conversation
Member
Author
|
Just removing the code pieces makes that If an amenment deleted three line and (e.g. line 3-5) and a CR is added to line 4 then the CR is only on line 4. The newest commit is checking if the line above really belong to the to be looked at lines (I think) |
Elblinator
marked this pull request as ready for review
July 31, 2026 09:05
bastianjoel
reviewed
Aug 19, 2026
| lineRange.from = Math.min(newLnRange.from, lineRange.from); | ||
| lineRange.to = Math.max(newLnRange.to, lineRange.to); | ||
| } else { | ||
| } else if (!toLnElement.parentElement.classList.contains(`merge-before`)) { |
Member
There was a problem hiding this comment.
Can you elaborate where you got this condition from and what merge-before is supposed to indicate?
The class seems a bit like a leftover to me as it is currently seemingly nowhere used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #6394
https://github.com/OpenSlides/openslides-client/pull/6209/changes
I tested all three issues this PR fixes and I could not detenct changes in behaviour:
#5016 (Amendment with all crossed out content: change reco not possible)
#6157 (Change recommendation: Doesn't work with completly deleted text in amendments)
#6215 (Issues with change recommendations on amendments)