Feature/add expands fields relations to get user by id v2 - #148
Conversation
Wires SerializerUtils::getExpand()/getFields()/getRelations() into both by-ID user endpoints (matching the ParametrizedGetAll pattern already used by list endpoints), and makes PrivateUserSerializer treat `groups` as a gated relation (mirroring ApiScopeGroupSerializer) instead of appending it unconditionally. Unblocks ftn-docsnsklz PR #76 (SDS ftn-attendee-native-realtime-comms.md, D38): attendee-networking-api's IDP user_updated consumer needs to fetch exactly fields=public_profile_allow_chat_with_me,first_name,last_name,pic without pulling the rest of the private profile. v1 get() also migrated from manual try/catch to the shared processRequest() wrapper for consistent error handling with getV2(). Also fixes an unrelated pre-existing bug in UserLoginTurnstileTest where $testEmail/$testPassword being typed as non-nullable string caused a TypeError before the test's own markTestSkipped() logic could run when TEST_USER_EMAIL/TEST_USER_PASSWORD are unset. 9 new tests added to OAuth2UserApiTest; full suite green (180 tests, 0 failures, 7 legitimate skips).
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-148/ This page is automatically updated on each push to this PR. |
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-148/ This page is automatically updated on each push to this PR. |
Address deep-review findings on PR #148: - OA\Get annotation for GET /api/v1/users/{id} was missing the `expand` parameter even though get() already passed SerializerUtils::getExpand() into serialize() -- the capability was live but undocumented. - v1 lacked a default-shape regression test symmetric with testGetUserByIdV2WithNoParamsReturnsSameShapeAsBefore, so the fields/relations passthrough's backward compatibility on v1 was only exercised incidentally.
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-148/ This page is automatically updated on each push to this PR. |
https://app.clickup.com/t/9014802374/86bb1u6vx