Skip to content

fix(binding): forward projected location writes - #1049

Merged
Kyle-Ye merged 1 commit into
codex/stored-location-testsfrom
feature/observable_location
Sep 6, 2026
Merged

fix(binding): forward projected location writes#1049
Kyle-Ye merged 1 commit into
codex/stored-location-testsfrom
feature/observable_location

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Write the updated base value through the underlying location with the original transaction.
  • Add regression coverage for the stored value, unchanged fields, transaction forwarding, and exactly one underlying write.
  • Update binding projection tests to check both the projected value and the underlying storage after writes.

Stack

Depends on #1048.

@github-actions github-actions Bot added area: data-flow State, binding, environment, preference, observation, or property data flow. type: bug Something is not working correctly. labels Sep 6, 2026
@Kyle-Ye
Kyle-Ye force-pushed the feature/observable_location branch from 7c5ba3a to 3f27ee7 Compare September 6, 2026 17:07
@tuist

tuist Bot commented Sep 6, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1161 0 1161 2b1dde006

Failed Tests ❌

  • OpenSwiftUI: 13 failed tests (View all)

  • set() · OpenSwiftUICoreTests · ForceUnwrappingTests
    (unwrappedBinding.wrappedValue → 20) == 10

  • setFromCGFloat() · OpenSwiftUICoreTests · ToDoubleTests
    (doubleBinding.wrappedValue → 2.71828).isApproximatelyEqual(to: 1.0)

  • withString() · OpenSwiftUICoreTests · EqualsTests
    (resultBinding2.wrappedValue → true) == false

  • setFromFloat() · OpenSwiftUICoreTests · ToDoubleTests
    (doubleBinding.wrappedValue → 2.5).isApproximatelyEqual(to: 1.0, absoluteTolerance: 0.001)

  • set() · OpenSwiftUICoreTests · ToDoubleFromIntegerTests
    (doubleBinding.wrappedValue → 25.0) == 10.0

Showing 5 of 13 failed tests. See links above for full details.

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 1m 41s 2b1dde006

@Kyle-Ye
Kyle-Ye force-pushed the feature/observable_location branch from 3f27ee7 to 880a129 Compare September 6, 2026 17:53
@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.13%. Comparing base (df0926b) to head (880a129).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           codex/stored-location-tests    #1049      +/-   ##
===============================================================
+ Coverage                        17.10%   17.13%   +0.02%     
===============================================================
  Files                              735      735              
  Lines                            53936    53937       +1     
===============================================================
+ Hits                              9226     9242      +16     
+ Misses                           44710    44695      -15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 0e5fb9d into main Sep 6, 2026
3 of 5 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/observable_location branch September 6, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: data-flow State, binding, environment, preference, observation, or property data flow. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant