Skip to content

refactor: use WeakAttribute.base directly - #1055

Merged
Kyle-Ye merged 1 commit into
mainfrom
feature/weak
Sep 7, 2026
Merged

refactor: use WeakAttribute.base directly#1055
Kyle-Ye merged 1 commit into
mainfrom
feature/weak

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Update the OpenAttributeGraph and DarwinPrivateFrameworks revisions to include public WeakAttribute.base access.
  • Remove redundant weak attribute conversions in GraphHost.asyncTransaction and WeakAttribute.uncheckedIdentifier by accessing base directly.

Validation

Standalone clients compiled successfully with OpenAttributeGraph and AttributeGraph. The AttributeGraph client also linked successfully.

Dependency

@github-actions github-actions Bot added area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. type: maintenance Refactor, cleanup, dependency bump, NFC, or internal maintenance. labels Sep 7, 2026
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.82%. Comparing base (f8368c4) to head (239e5d0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/Graph/GraphHost.swift 0.00% 1 Missing ⚠️
...OpenSwiftUICore/Util/AttributeGraphAdditions.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   27.31%   29.82%   +2.50%     
==========================================
  Files         735      783      +48     
  Lines       54011    61727    +7716     
==========================================
+ Hits        14755    18407    +3652     
- Misses      39256    43320    +4064     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Sep 7, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1163 0 1163 d0d294961

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 57.0s d0d294961

@Kyle-Ye
Kyle-Ye merged commit 0e1871c into main Sep 7, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/weak branch September 7, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. type: maintenance Refactor, cleanup, dependency bump, NFC, or internal maintenance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant