Skip to content

[elistbox] fix wrap-around logic for selection movement at boundaries #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DimitarCC wants to merge 2 commits into from
Closed

[elistbox] fix wrap-around logic for selection movement at boundaries #1300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
add02d3
[elistbox] fix wrap-around logic for selection movement at boundaries
DimitarCC Aug 22, 2026
9e8358a
[elistbox] refine wrap-around logic to consider orientation for selec…
DimitarCC Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/gui/elistbox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,9 +481,9 @@ void eListbox::moveSelection(long dir)
break;
case pageUp:
case prevPage: {
if (m_enabled_wrap_around && oldsel < m_items_per_page)
if (m_orientation == orHorizontal && m_enabled_wrap_around && oldsel == 0)
{
// already on the first page, wrap around to the last selectable entry
// already at the first entry, wrap around to the last selectable entry
m_content->cursorEnd();
m_content->cursorMove(-1);
newsel = m_content->cursorGet();
Expand Down Expand Up @@ -534,9 +534,9 @@ void eListbox::moveSelection(long dir)
}
case pageDown:
case nextPage: {
if (m_enabled_wrap_around && oldsel >= ((m_content->size() - 1) / m_items_per_page) * m_items_per_page)
if (m_orientation == orHorizontal && m_enabled_wrap_around && oldsel == m_content->size() - 1)
{
// already on the last page, wrap around to the first selectable entry
// already at the last entry, wrap around to the first selectable entry
m_content->cursorHome();
newsel = m_content->cursorGet();
while (newsel != oldsel && !m_content->currentCursorSelectable())
Expand Down
Loading