Conversation
Pool initialization is permissionless, and the claim tokens the hook holds carry no pool component. State the PoolId keying requirement for multi-pool hooks and the _beforeInitialize binding for single-pool ones.
gonzaotc
marked this pull request as ready for review
September 7, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool initialization is permissionless, so any pool can name this hook, and the claim tokens it holds are keyed by currency with no pool component. The old note asked for per-pool separation without saying either fact.
The hook has no
_beforeInitializeto hang this on, so the warning sits on the contract. Stacked on #173, which edits the block above it.