Skip to content

Move focal gain LUT to packaged JSON resource - #488

Open
HussainAther wants to merge 1 commit into
OpenwaterHealth:mainfrom
HussainAther:issue-448-focal-gain-lut-resource
Open

Move focal gain LUT to packaged JSON resource#488
HussainAther wants to merge 1 commit into
OpenwaterHealth:mainfrom
HussainAther:issue-448-focal-gain-lut-resource

Conversation

@HussainAther

Copy link
Copy Markdown

Closes #448

Summary

  • move the focal gain lookup table out of src/openlifu/xdc/util.py
  • store it as a packaged JSON resource
  • load it with importlib.resources
  • preserve the existing xarray.DataArray behavior
  • include the JSON file in package data

Testing

  • 324 passed
  • 2 skipped on macOS as expected

@HussainAther
HussainAther force-pushed the issue-448-focal-gain-lut-resource branch from 300444c to 2437059 Compare August 8, 2026 16:00
@ebrahimebrahim
ebrahimebrahim force-pushed the issue-448-focal-gain-lut-resource branch from 2437059 to 7df0714 Compare August 28, 2026 16:18
@ebrahimebrahim

Copy link
Copy Markdown
Collaborator

This looks good on first glance; planning to do a proper review and integrate this in a couple of weeks if no one gets to it before me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save Focal Gain LUT into a data file (json, csv, etc.) to make the source code file shorter.

2 participants