Fix stale volume file on overwrite - #497
Open
HussainAther wants to merge 1 commit into
Open
Conversation
Collaborator
|
This looks good on first glance; planning to do a proper review and integrate this in a couple of weeks if no one gets to it before me. Thank you! |
ebrahimebrahim
force-pushed
the
fix/issue-136-volume-overwrite-cleanup
branch
from
August 28, 2026 16:15
cd77c54 to
75284c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136.
When
Database.write_volume()overwrites an existing volume using a differentsource filename, the previously associated volume data file remains in the
database directory.
This change records the existing volume data file before overwrite and removes
it after the replacement file has been copied successfully.
Validation:
pytest tests/test_database.py -k issue_136 -v