Skip to content

feat: admin can't revoke their own role #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuentinMory wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: admin can't revoke their own role #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74e8c27
feat: admin can't revoke their own role
QuentinMory Sep 1, 2026
56323e3
fix: change variable name
QuentinMory Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions backend/src/main/java/ch/sectioninformatique/template/user/UserController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,20 @@ public Mono<ResponseEntity<String>> revokeAdmin(@RequestHeader("Authorization")
@PreAuthorize("hasAuthority('user:update')")
public Mono<ResponseEntity<String>> downgradeAdmin(@RequestHeader("Authorization") String token,
@PathVariable String userLogin) {

Authentication authentication = SecurityContextHolder
.getContext()
.getAuthentication();

UserDto currentUser = (UserDto) authentication.getPrincipal();
if (currentUser.getLogin().equals(userLogin)) {
String message = messageSource.getMessage(
"user.downgrade.self",
null,
LocaleContextHolder.getLocale());
return Mono.just(ResponseEntity.badRequest().body(message));
}

// Call auth service to downgrade admin to manager globally
return authClient.downgradeAdmin(token, userLogin)
.flatMap(response -> {
Expand Down
1 change: 1 addition & 0 deletions backend/src/main/resources/messages/user/messages_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ user.duplicate=Duplicate user detected: {0}
user.delete.permanent.failed=Failed to permanently delete user: {0}
user.deleted.local=Local user deleted successfully
user.promoted.local=User promoted to local app role successfully
user.downgrade.self=You cannot downgrade your own role
1 change: 1 addition & 0 deletions backend/src/main/resources/messages/user/messages_fr.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ user.duplicate=Utilisateur en double détecté : {0}
user.delete.permanent.failed=Échec de la suppression définitive de l''utilisateur : {0}
user.deleted.local=Utilisateur local supprimé avec succès
user.promoted.local=Utilisateur promu au rôle local de l''application avec succès
user.downgrade.self=Vous ne pouvez pas rétrograder votre propre rôle