tablets: Fix some issues where the tablet would not update on a server. - #82
Merged
Merged
Conversation
AmandaCameron
force-pushed
the
fix-tablets
branch
from
August 25, 2026 14:13
2ff0100 to
a428afd
Compare
AmandaCameron
marked this pull request as draft
August 25, 2026 19:56
Author
|
This is completely incorrect to be fixing the issue. Investigating myself now. |
AmandaCameron
force-pushed
the
fix-tablets
branch
from
August 25, 2026 21:45
ff92209 to
9271009
Compare
Author
|
Force pushed with a (partial) fix. For some reason the tablet shows as on when you take it out of the charger though, but I'm not sure how to fix that, and I'm rather low on spoons for today. |
AmandaCameron
marked this pull request as ready for review
August 26, 2026 12:51
Author
|
Combined with 594822f (which I rearranged slightly in this PR) the tablet appears to be working as intended now. |
For some reason, when taking the tablet out of a charger it will not re-initialize the TextBuffer, causing the display to not update.
The code was unnessarially calling tablet.writeDataNBT twice, so I rearranged the code to get rid of the duplicate call.
AmandaCameron
force-pushed
the
fix-tablets
branch
from
August 26, 2026 18:25
f1871ff to
a115184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.