Skip to content

Resolve releases from owned labels and effective settings #111

Description

Outcome

Resolve all supported settings before GitHub-Script starts. Repository and workflow maintainers can set each of the 16 supported settings in the selected settings file or through its matching named action input.

Apply standard defaults, selected repository settings, then known nonempty named inputs. Explicit false and values equal to standards remain overrides. Null and empty named inputs retain file values. Validate every supplied layer, including invalid values that a later override could mask.

Acceptance scenarios

Scenario: Startup settings use the same configuration contract
  Given valid standards and a selected repository settings file
  When the file sets Debug, Verbose, WorkingDirectory, Version, or Prerelease
  Then those values are resolved before GitHub-Script starts
  And the action receives the resolved startup values
  And Version and Prerelease control only the GitHub module dependency
  And the release script receives the resolved release policy without another merge

Scenario: Named inputs retain ordinary omission and override behavior
  Given file values that differ from the standards
  When known named inputs are omitted, null, or empty
  Then file values remain effective
  When the caller supplies false or a nonempty value equal to the standard
  Then that named input overrides the file
  And supported empty text can be configured in the file
  And invalid standards, file values, or nonempty inputs fail even when masked

Scenario: File selection precedes execution-directory selection
  Given an explicitly supplied WorkingDirectory or otherwise github.workspace
  When SettingsFilePath is relative
  Then that known initial directory selects the settings file
  And the file is read once
  And relative WorkingDirectory values resolve from github.workspace
  And a file-defined WorkingDirectory changes execution without selecting another file
  And literal custom paths with spaces and brackets remain supported
  And an absent selected file uses valid standards and named inputs
  And invalid paths or settings fail before GitHub-Script starts

Scenario: The private schema owns standards and supported types
  Given one private metadata declaration in action.yml
  When the bootstrap reads its own action metadata
  Then it validates the complete schema and every supplied layer
  And file-configurable named inputs have no concrete native defaults
  And their descriptions show the effective standards
  And SettingsFilePath remains a selector, not a settings-file key

Scenario: Cleanup uses the actual version boundary
  Given effective VersionPrefix release-1.2.3-
  And generated own-branch tag release-1.2.3-2.0.4-feature.1
  When cleanup selects feature prereleases
  Then it selects that release
  Given effective VersionPrefix release-1.2.3-feature.extra-
  And generated other-branch tag release-1.2.3-feature.extra-2.0.4-other.1
  When cleanup selects feature prereleases
  Then it does not select that release
  And empty and hyphenated prefixes remain valid
  And cleanup after a prefix change follows an explicit documented retention rule

Scenario: Owned release decisions and separate delivery layers remain intact
  Given the five owned release labels and valid effective settings
  When the controller evaluates a pull request
  Then it retains the existing bump, mode, skip, reviewed-head, and cleanup behavior
  And VersionPrefix remains configurable with standard default v
  And publication concurrency remains unchanged
  And this lower layer keeps .github\auto-release.yml

Scope

This Task and #109 own the resolver, early bootstrap, matching named inputs, coupled cleanup fix, tests, README, and caller adoption record.

The five startup controls join the existing 11 release-policy settings: Debug, Verbose, WorkingDirectory, Version, and Prerelease. Prerelease controls GitHub-module dependency selection, not repository prerelease mode. Use release:prerelease for that mode.

The canonical .github\release.settings.yml selector default and removed-path guard belong only to #115 / #116. This layer retains .github\auto-release.yml. No upper worktree, upper PR body, or Task 115 change is included.

#111 remains natively blocked by #112. The scoped implementation proceeds in the existing draft at the user's request; the blocker still prevents finalization. Do not edit 112, 108, consumer templates, rulesets, live permissions, releases, or tags. Keep PR 109 draft and auto-merge off. No merge or publication is authorized.

Technical decisions

  • src\Initialize-ReleaseConfiguration.ps1 reads the selected file before GitHub-Script starts. Its helper module reads the private schema from the action's own metadata.
  • The private schema defines each setting's type, standard, and startup or release-policy destination once. Input descriptions display effective standards. Only SettingsFilePath retains its separate native selector default.
  • The bootstrap resolves relative named WorkingDirectory values from github.workspace. It selects relative SettingsFilePath from that explicitly supplied directory, or otherwise from github.workspace. File-defined execution directories do not cause another file read.
  • The bootstrap outputs Debug, Verbose, WorkingDirectory, Version, and Prerelease for GitHub-Script. It outputs ReleaseSettings as JSON for the release script's private resolved-settings handoff.
  • main.ps1 consumes resolved policy. It does not read the settings file or merge raw inputs after startup.
  • Cleanup uses the effective prefix as the version boundary. Automatic cleanup retains tags under other historical prefixes; the README and adoption record state this limit.
  • No bundled defaults asset, omission token, presence heuristic, extra override flag, public mapping input, or parallel vocabulary is added. Publication authority, counters, and lifecycle remain outside scope.

Implementation plan

  • Inspect the starting branch, issue dependencies, real resolver/controller, action wiring, and current standards.
  • Fix the bootstrap reader path and private handoff design; notify the filename-layer coordinator.
  • Add focused failing cases for all five startup settings, real bootstrap path/precedence behavior, and the two PSSemVer 1.1.10 cleanup counterexamples.
  • Extend the private schema, remove startup native defaults, and resolve all settings before GitHub-Script.
  • Pass resolved startup values and release policy through the actual composite interface.
  • Fix prefix-aware cleanup and document the historical-prefix retention rule.
  • Remove the workflow-expression snapshot assertions without changing concurrency behavior.
  • Run current-source Pester and PSScriptAnalyzer checks, plus the existing read-only caller job where feasible.
  • Update README, input descriptions, and PR 109 with caller-first adoption guidance, four-column alignment evidence, accurate source/test results, and the conditional Major/Stable decision.
  • Push small ordinary commits on the existing branch and report the exact head, paths, evidence, metadata changes, and remaining blocker to the coordinator.

Evidence and gates

Starting head: 714b801478b5c60565fcfb99ac66b440872f5250. PR base: 750abed0ecab02394554b610dc3aa191e75e3248 on main.

Core commit 7ab87bc07d58a513716e50c947d76852fc6065e9, tree abdca0fdd32d9cf9fe1cc752f13a3b6e631f9187, is committed and pushed. Its local Pester 6.1.0 run passes all 223 repository cases, with zero failures, skips, or not-run cases. PSScriptAnalyzer 1.25.0 examines five PowerShell files with zero diagnostics. The README passes Markdown lint. The related workflows pass actionlint 1.7.12; offline zizmor reports no findings under the existing suppressions.

The test-first control executes 28 failing cases at the starting source. Eight reject the unsupported startup fields, 18 require the new bootstrap, and two use the real resolver plus PSSemVer 1.1.10 to reproduce the cleanup counterexamples. Current tests also verify actual runner output commands and that the controller retains its resolved policy after raw inputs and the file change.

Final source is 1040867819d77ef79c88d4492e10e8a8a7b6a37b, tree 71b3ccb5bbb9e7daa70fc559c0789a6ee405a662. It adds only 15 caller-workflow lines to the core commit. The exact-head native Pester job executes all 223 cases, with zero failures, skips, or not-run cases. The final-source focused local run passes 53 selected cases; 170 cases are outside that filter. Five PowerShell files have zero analyzer diagnostics.

The actual read-only caller job passes both invocations and fixture cleanup. Each invocation has five observed GitHub-Script startup fields and seven observed controller-policy fields. File Debug/Verbose/Prerelease true, Version [0.43.1], and .github execution directory remain effective through empty inputs. Named false values and the standard workspace override those file settings. Policy remains major/RepositorySetting versus patch/ActionInput. False and retained file text are verified without using the final version as the policy oracle.

Exact-head Action-Test, lint, all 13 lint contexts, actions analysis, and CodeQL pass. The old 179-case results, earlier reviews, upper-source synchronization, and anonymous controls do not establish this revision's results.

The fresh review is COMMENTED, effort Lite, with three findings. Its backslash-path claim was disproved by the actual Ubuntu default-file read and resolved with evidence. The merged-event checkout-source and non-PR label-mutation findings remain open. This assignment leaves publication/event authority unchanged, so those threads remain separate readiness limits. The review is not approval.

The PR 109 record now contains caller-first migration instructions, all 16 settings, the bootstrap path and handoff, the prefix-retention rule, current exact-source validation, and canonical four-column alignment tables. It retains the conditional Major/Stable decision and the existing release:major label. PR 109 is still draft, auto-merge is off, and no publication is authorized.

The final scoped handoff was delivered to the existing PR 116 coordinator. It identifies the exact lower head and tree, eight changed paths from the starting head, current local/native results, metadata changes, and unresolved readiness limits. No further lower source change is pending.

Live publication and concurrency contention are not authorized by this task. Local behavior checks and the read-only caller job do not establish those production contracts. Native blocker #112 and the separate controlled-publication/template prerequisites remain open.

The original split and all prior commits remain in history. Use ordinary additive commits only; do not amend or force-push.

Activity

  1. changed the title [-]Owned release controls and effective settings determine repository releases[/-] [+]Resolve repository releases from owned decisions and effective settings[/+] on Oct 31, 2026
  2. MariusStorhaug commented on Oct 31, 2026

    @MariusStorhaug
    MemberAuthor

    Reframed this delivery around maintainer-visible Given/When/Then outcomes. Implementation choices, bootstrap verification, migration details, and review progress remain in the linked design and existing PR; publication authority and governance remain separate work.

  3. MariusStorhaug commented on Oct 31, 2026

    @MariusStorhaug
    MemberAuthor

    Restored the technical Task decisions and test-first plan after the clarified aggregate-only guidance. Consumer scenarios remain first; implementation ownership and the verified review fixes are retained below them, with no publication or governance action.

  4. MariusStorhaug commented on Oct 31, 2026

    @MariusStorhaug
    MemberAuthor

    Recorded the decision-enforcement Task as a native readiness prerequisite and updated the candidate documentation link to the verified immutable head. Passing tests and advisory CI do not replace the missing protected-branch decision requirement; the existing PR stays draft, with no live policy change.

  5. MariusStorhaug commented on Oct 31, 2026

    @MariusStorhaug
    MemberAuthor

    Completed the bounded implementation/test/review plan and recorded the verified head and summary assessment. The Task remains open with its native governance prerequisite; no draft SHA is promoted to a production dependency, and no merge/publication/policy action was taken.

  6. MariusStorhaug commented on Nov 1, 2026

    @MariusStorhaug
    MemberAuthor

    User-directed scope amendment: the actual release reader now adopts the canonical name.settings.yml convention. The new filename/migration cases were written before changing the reader; old conventional paths will fail rather than be ignored or loaded as fallback. No production file, release, tag or governance policy is changed.

  7. MariusStorhaug commented on Nov 1, 2026

    @MariusStorhaug
    MemberAuthor

    Implemented the filename revision after its tests failed on the prior reader, preserving the existing settings/label/custom-path interfaces. The new source/default is published as development evidence in the existing PR and #108 handoff; canonical correspondence and full review are still evaluated before readiness.

  8. MariusStorhaug commented on Nov 1, 2026

    @MariusStorhaug
    MemberAuthor

    The completed filename revision now has an explicit consumer scenario and pinned current-source/canonical/review evidence, with its technical plan retained. Previous resolver-source evidence is identified as historical. Native readiness and publication authorization remain separate; no live publication or governance action was taken.

  9. MariusStorhaug commented on Nov 1, 2026

    @MariusStorhaug
    MemberAuthor

    Verified the final MSXOrg/docs#233 naming/module/release guidance at immutable 734145479ede01a7ccdeb4eb29950d405ed99a09 and updated the correspondence links. The #109 reader source remains 03e20b8; conventional naming, explicit custom paths and the PSModule.yml/SettingsPath exception are unchanged. No unmerged documentation branch was imported and no production or governance action occurred.

  10. changed the title [-]Resolve repository releases from owned decisions and effective settings[/-] [+]Resolve releases from owned labels and effective settings[/+] on Nov 13, 2026
  11. MariusStorhaug commented on Nov 13, 2026

    @MariusStorhaug
    MemberAuthor

    User-directed additive split: this leaf retains owned labels/effective settings and their coupled correctness tests/docs. The already-implemented filename default/guard/cases/adoption record move together to Task115 above this layer. Original03e20b8 is preserved; current3e1b28e equals the approved pre-filename resolver tree exactly. Historical comments remain, native112 remains, and no merge/publication or history rewrite occurs.

  12. MariusStorhaug commented on Nov 13, 2026

    @MariusStorhaug
    MemberAuthor

    Both topic PRs now exist in native stack117:109 retains this resolver leaf and116 closes only the dependent filename leaf115. Original source/history is preserved, cumulative tree and original filename patch equality are independently verified, and lower new-head validation is recorded. Upper current-head review evidence stays with its owner; both drafts and native112 remain, with no merge/publication or ruleset change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions