Repository navigation
docs: the IP allow-list is per API credential, not for the admin area - #446
Merged
Merged
Conversation
The README listed IP whitelisting for the admin area. There is none: the allow-list is on API credentials (ApiKeyAuth, docs/api/credentials.md).
Owner
|
Merged — thank you for going back for the claim you had left open in #440. A README that promises an admin-area IP restriction nobody implemented is the kind of line a buyer quotes back at you. Checked: the allow-list really is per API credential ( |
Owner
|
Released in 1.29.0 — thank you. Gates on the tag: the full suite 5426 passed, 0 failed; the update lab's 14 scenarios green on a run of its own; the real package updating 1.28.0 on the stable channel and the last beta on the beta channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's security list said "IP whitelisting for admin area (optional)". There is no such restriction on the admin area. The allow-list that exists is per API credential: the addresses and CIDR ranges a key may be used from (
ApiKeyAuth, documented indocs/api/credentials.md).One line in
README.mdnow says that. This is the claim left unchecked in #440; the other two I left open there (session timeout with force logout, and saved bank accounts with a default) are right as written.