Repository navigation
feat(orders): an order placed by staff charges the product's setup fee - #447
Conversation
The new order form left the setup fee out, so a plan sold at '10 a month plus 25 setup' was billed 10 when staff raised it and 35 when the customer ordered it. The form now charges it as the shop does, with a box staff can clear when the sale waives it.
|
Merged — thank you. "The same plan billed 35 to a customer and 10 to staff" is exactly the kind of difference nobody notices until the accounts are reconciled. Measured before it went in:
Noting your "not in this PR" for the record: the API Merging is not shipping: this reaches installations with the next release. |
|
Released in 1.29.0 — thank you. Gates on the tag: the full suite 5426 passed, 0 failed; the update lab's 14 scenarios green on a run of its own; the real package updating 1.28.0 on the stable channel and the last beta on the beta channel. |
What was wrong
The new order form in the admin area left the product's setup fee out. A plan sold at "10 a month plus 25 setup" was billed 35 when the customer ordered it and 10 when staff placed the same order for them. This is the follow-up promised in #411.
What changes
One new text (
admin.orders.new_setup_fee), in all nine languages. No migration, no setting.Not in this PR
The API
AddOrderstill places orders without the setup fee. Adding it there changes what existing integrations are billed, so it wants a parameter and a decision on the default. I can follow up.Tests
AdminOrderSetupFeeTest(6): charged as its own line; charged when the field is not sent; left off when the box is cleared; added to a staff-set price; nothing for a product without a fee; the box is on the form, ticked. Full suite run in two halves.