Skip to content

fix(domains): an ordered transfer keeps the pending status its module records - #460

Merged
Panelica merged 1 commit into
Panelica:mainfrom
ertugrulkeyvan:fix/transfer-keeps-pending-status
Nov 18, 2026
Merged

Panelica merged 1 commit into
Panelica:mainfrom
ertugrulkeyvan:fix/transfer-keeps-pending-status

Conversation

@ertugrulkeyvan

Copy link
Copy Markdown
Contributor

What was wrong

When a paid order contains a domain transfer, OrderService::transferOrderedDomain() calls the registrar's transfer() and then writes:

'status' => $result['status'] ?? DomainStatus::Active->value,

DomainNameAPI, Enom, HRD, Namecheap and ResellerClub record the started transfer on the domain themselves (pending_transfer, or Pending Transfer). They do not return a status, so this line wrote active over it. The panel showed the domain as live while the losing registrar had not released it yet. Only OVH and Manual return the status, so their transfers kept it.

Reported in the community: https://community.pnlcs.com/t/43

The change

  • A status the module returns still wins.
  • Otherwise, if the module changed the domain's status during the call, that status is kept.
  • A module that leaves the status untouched (Openprovider today) still gets active, as before.

The daily registrar sync already moves the domain on: syncDomain() reports the registry's status, and DomainSyncCommand applies it once the transfer completes.

Tests

tests/Feature/DomainTransferStatusTest.php covers a module that writes the status, one that returns it, and one that does neither. On main, the first fails; with the change, all three pass. Full suite: 5,429 passed; the 2 failures (CurrencyAndBackupTest, MailLinkHostTest) fail the same way on main.

… records

DomainNameAPI, Enom, HRD, Namecheap and ResellerClub mark a started
transfer as pending on the domain themselves and return no status. The
order step then wrote 'active' over it, so a domain the losing registrar
had not released yet showed as live.

A status the module returns still wins; otherwise a status the module
wrote during the call is kept; only a module that leaves the status
untouched gets 'active' as before. The registrar sync moves the domain on
once the transfer completes.
@Panelica
Panelica merged commit 7f7a629 into Panelica:main Nov 18, 2026
1 check passed
@Panelica

Copy link
Copy Markdown
Owner

Merged, thank you.

Verified: $domain->fresh() is read before the update(), so the status a module wrote during transfer() is what stands, and a module that says nothing still leaves the domain active. 1 of 3 tests red on 1.29.0, the other two are guards for the paths that already worked. Measured on the merge result: the full suite is green — 5463 passed in parallel (--exclude-group=serial, 4 processes) plus the 17 serial installer tests, 5 skipped, 0 failed.

One note for later: a module that writes the same status it was given (pending → pending) falls into the "said nothing" branch. Harmless today — none of the shipped modules do that.

@Panelica

Copy link
Copy Markdown
Owner

Released in 1.30.0, the stable channel, offered to every installation.

Gates on the tag and that package: full suite 5463 passed in parallel plus the 17 serial installer tests (0 failed, 5 skipped); 276 translation and parity tests green; the update lab 14 scenarios ALL GREEN; the real package updated the last stable (1.29.0 → 1.30.0, 13 checks) and the last beta (1.25.1-beta.1 → 1.30.0, 14 checks), each installed from its published package in the published runtime image with the signature checked by the key built into the application; the three uploaded assets re-downloaded and compared byte for byte before publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants