Repository navigation
fix(domains): an ordered transfer keeps the pending status its module records - #460
Conversation
… records DomainNameAPI, Enom, HRD, Namecheap and ResellerClub mark a started transfer as pending on the domain themselves and return no status. The order step then wrote 'active' over it, so a domain the losing registrar had not released yet showed as live. A status the module returns still wins; otherwise a status the module wrote during the call is kept; only a module that leaves the status untouched gets 'active' as before. The registrar sync moves the domain on once the transfer completes.
|
Merged, thank you. Verified: One note for later: a module that writes the same status it was given (pending → pending) falls into the "said nothing" branch. Harmless today — none of the shipped modules do that. |
|
Released in 1.30.0, the stable channel, offered to every installation. Gates on the tag and that package: full suite 5463 passed in parallel plus the 17 serial installer tests (0 failed, 5 skipped); 276 translation and parity tests green; the update lab 14 scenarios ALL GREEN; the real package updated the last stable (1.29.0 → 1.30.0, 13 checks) and the last beta (1.25.1-beta.1 → 1.30.0, 14 checks), each installed from its published package in the published runtime image with the signature checked by the key built into the application; the three uploaded assets re-downloaded and compared byte for byte before publishing. |
What was wrong
When a paid order contains a domain transfer,
OrderService::transferOrderedDomain()calls the registrar'stransfer()and then writes:DomainNameAPI, Enom, HRD, Namecheap and ResellerClub record the started transfer on the domain themselves (
pending_transfer, orPending Transfer). They do not return a status, so this line wroteactiveover it. The panel showed the domain as live while the losing registrar had not released it yet. Only OVH and Manual return the status, so their transfers kept it.Reported in the community: https://community.pnlcs.com/t/43
The change
active, as before.The daily registrar sync already moves the domain on:
syncDomain()reports the registry's status, andDomainSyncCommandapplies it once the transfer completes.Tests
tests/Feature/DomainTransferStatusTest.phpcovers a module that writes the status, one that returns it, and one that does neither. On main, the first fails; with the change, all three pass. Full suite: 5,429 passed; the 2 failures (CurrencyAndBackupTest, MailLinkHostTest) fail the same way on main.