Skip to content

fix(invoices): payment return messages, refunds and the address label on the invoice screens - #461

Merged
Panelica merged 1 commit into
Panelica:mainfrom
ertugrulkeyvan:fix/admin-invoice-refund-and-labels
Nov 18, 2026
Merged

Panelica merged 1 commit into
Panelica:mainfrom
ertugrulkeyvan:fix/admin-invoice-refund-and-labels

Conversation

@ertugrulkeyvan

Copy link
Copy Markdown
Contributor

Fixes #451, #453, #454. All three are on the invoice screens, and each is a few lines.

#451: payment return messages

Client\InvoiceController::flashPaymentOutcome() maps ?payment=success|failed|orphan to messages.iyzico.paid, .failed and .invoice_missing. Those keys existed in no language, so the customer saw the raw key.

Mollie, Authorize.Net and the generic webhook flow send the customer back with the same ?payment= codes. So the sentences are in a gateway-neutral messages.payment_return block, added to the nine languages that have a messages.php. Other languages fall back to English, as they do for the rest of that file. not_configured stays under messages.iyzico, where it already exists.

#453: refunds in the payment history

The admin payment history printed +amount_in for every transaction. A refund has amount_in = 0 and the money in amount_out, so it showed as "+0.00". A row with money going out now shows -amount_out in red.

#454: address label

The buyer's address row used admin.invoices.name. It now uses common.form.address, the same way the email row above it uses common.form.email.

Tests

tests/Feature/InvoicePaymentHistoryTest.php has 5 tests. All fail on main and pass with the change. Full suite: 5,431 passed; the 2 failures (CurrencyAndBackupTest, MailLinkHostTest) fail the same way on main.

… on the invoice screens

- A customer sent back to the invoice with ?payment=success|failed|orphan
  saw the raw key (messages.iyzico.paid and two others), which existed in
  no language. Mollie, Authorize.Net and the generic webhook flow send the
  same codes, so the sentences live in a gateway-neutral
  messages.payment_return block, in the nine languages that have a
  messages file.
- The admin payment history printed +amount_in for every row, so a refund
  showed as "+0.00". A row with money going out now shows -amount_out.
- The buyer's address row was labelled with admin.invoices.name; it uses
  common.form.address like the email row above it uses common.form.email.

Fixes Panelica#451, Panelica#453, Panelica#454.
@Panelica
Panelica merged commit 69052b6 into Panelica:main Nov 18, 2026
1 check passed
@Panelica

Copy link
Copy Markdown
Owner

Merged, thank you.

Checked the three keys in all nine languages: messages.payment_return.* and common.form.address are present everywhere, and messages.iyzico.not_configured — the one key of the four that did exist — is untouched. The refund row reads amount_out, which is where a refund's money is, so "+0.00" is gone. All five tests red on 1.29.0, green after. Measured on the merge result: the full suite is green — 5463 passed in parallel (--exclude-group=serial, 4 processes) plus the 17 serial installer tests, 5 skipped, 0 failed.

@Panelica

Copy link
Copy Markdown
Owner

Released in 1.30.0, the stable channel, offered to every installation.

Gates on the tag and that package: full suite 5463 passed in parallel plus the 17 serial installer tests (0 failed, 5 skipped); 276 translation and parity tests green; the update lab 14 scenarios ALL GREEN; the real package updated the last stable (1.29.0 → 1.30.0, 13 checks) and the last beta (1.25.1-beta.1 → 1.30.0, 14 checks), each installed from its published package in the published runtime image with the signature checked by the key built into the application; the three uploaded assets re-downloaded and compared byte for byte before publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants