Repository navigation
fix(registrars): refuse a registration with missing registrant details instead of inventing them - #463
Conversation
…s instead of inventing them eNom, Namecheap, ResellerClub (customer signup) and Openprovider filled a missing detail with a placeholder - "Admin", "123 Main St", "Anytown", CA 90210, US, +1.5555555555 - and registered the domain under it. WHOIS then names nobody, which breaks registry accuracy rules and can cost the customer the domain. App\Support\RegistrantContact lists the details every registrar here needs (name, email, phone, address, city, country; state and postcode do not exist in every country). When one is empty the registration stops before anything is sent and the message names it; the admin can retry from the domain page once the client's profile is complete. Fixes Panelica#452.
|
Merged, thank you. Verified that nothing is left to invent a registrant: core builds the params with All 6 tests red on 1.29.0, green after. Measured on the merge result: the full suite is green — 5463 passed in parallel ( |
|
Released in 1.30.0, the stable channel, offered to every installation. Gates on the tag and that package: full suite 5463 passed in parallel plus the 17 serial installer tests (0 failed, 5 skipped); 276 translation and parity tests green; the update lab 14 scenarios ALL GREEN; the real package updated the last stable (1.29.0 → 1.30.0, 13 checks) and the last beta (1.25.1-beta.1 → 1.30.0, 14 checks), each installed from its published package in the published runtime image with the signature checked by the key built into the application; the three uploaded assets re-downloaded and compared byte for byte before publishing. |
Fixes #452.
What was wrong
eNom, Namecheap, ResellerClub (its customer signup) and Openprovider filled a missing registrant detail with a placeholder: "Admin", "123 Main St", "Anytown", CA 90210, US, +1.5555555555 (Openprovider: "Unknown", "00000"). Core leaves empty client fields out of the params (
OrderService::registerOrderedDomain()usesarray_filter), so the??fallbacks did fire. The domain was then registered under a WHOIS record that names nobody. That breaks registry accuracy rules and can cost the customer the domain.The change
App\Support\RegistrantContactlists the details every registrar here needs: first and last name, email, phone, address, city and country. State and postcode are left out, because not every country has them.Tests
tests/Feature/RegistrantPlaceholderTest.php: each of the four modules refuses a client with no phone or address, and no HTTP request goes out. A source check confirms no placeholder is left. On main, 5 of its 6 tests fail; with the change, all 6 pass. Full suite: 5,432 passed; the 2 failures (CurrencyAndBackupTest, MailLinkHostTest) fail the same way on main.