Repository navigation
feat(domains): a transfer needs an EPP code only where the extension does - #465
Conversation
…does Some registries move a name without an EPP/auth code: a .uk transfer is approved with the gaining registrar's IPS tag instead. Every transfer demanded a code anyway, in the cart, on the transfer page and in the order step, which left a code-less transfer for staff to start by hand. The domain_pricing table has had an epp_code flag (default on) since the first migration, but nothing read it and the extension form did not show it. Now: - DomainPricing::transferNeedsAuthCode() reads it; an unknown extension still needs a code. - The cart (hosting with a transfer, and add-domain) asks for the code only when the extension needs one; the transfer page no longer marks the field required, the server decides. - The order step sends a code-less transfer to the registrar when the extension needs none. - The extension form has the checkbox (label in the nine languages with their own admin file); a form without the field leaves the flag as it is.
|
Merged, thank you. Verified there is no migration needed: 3 of 4 tests red on 1.29.0. Measured on the merge result: the full suite is green — 5463 passed in parallel ( |
|
Released in 1.30.0, the stable channel, offered to every installation. Gates on the tag and that package: full suite 5463 passed in parallel plus the 17 serial installer tests (0 failed, 5 skipped); 276 translation and parity tests green; the update lab 14 scenarios ALL GREEN; the real package updated the last stable (1.29.0 → 1.30.0, 13 checks) and the last beta (1.25.1-beta.1 → 1.30.0, 14 checks), each installed from its published package in the published runtime image with the signature checked by the key built into the application; the three uploaded assets re-downloaded and compared byte for byte before publishing. |
What was missing
Some registries move a name without an EPP/auth code. A .uk transfer, for example, is approved with the gaining registrar's IPS tag. PNLCS asked for a code on every transfer: in the cart, on the transfer page and in the order step, which handed a code-less transfer to staff to start by hand.
domain_pricing.epp_code(boolean, default true) has been in the schema since the first migration, but nothing read it and the extension form did not show it. Raised in the community: https://community.pnlcs.com/t/43The change
DomainPricing::transferNeedsAuthCode($domain)reads the flag. An unknown extension still needs a code.required; the server decides.Tests
tests/Feature/TransferWithoutAuthCodeTest.php: .co.uk goes into the cart without a code, .com still asks for one, the order step sends''to the registrar, and the form sets and clears the flag. On main, 3 of the 4 fail; the .com test passes on both. Full suite: 5,430 passed; the 2 failures (CurrencyAndBackupTest, MailLinkHostTest) fail the same way on main.