Skip to content

fix(client): the other sign-in pages use the theme and the logo like login does - #469

Merged
Panelica merged 1 commit into
Panelica:mainfrom
ertugrulkeyvan:fix/client-auth-pages-theme
Nov 18, 2026
Merged

Panelica merged 1 commit into
Panelica:mainfrom
ertugrulkeyvan:fix/client-auth-pages-theme

Conversation

@ertugrulkeyvan

Copy link
Copy Markdown
Contributor

Fixes #458.

Only the client login page used the theme. Register, forgot-password, reset-password, two-factor and invite:

  • hard-coded the starter blues (#1a4d80, #337ab7, #405189);
  • ignored the uploaded logo;
  • in forgot-password, reset-password and invite, read --card, --border and --text, which nothing defined.

The change

  • client/auth/partials/theme-head adds the favicon, the theme variables, and the three variables those pages read, taken from the theme tokens.
  • client/auth/partials/brand shows the logo, or the shop's name in the theme colour. Register already showed the name; it now shows the logo too.
  • The brand colours go through --theme-primary and --theme-accent, with the old values as fallbacks. The error reds are unchanged.
  • The four pages that were missing from the ThemeComposer list are added.

Tests

tests/Feature/ClientAuthPagesThemeTest.php checks register, forgot-password and reset-password through their routes, and the two-factor and invite views rendered directly. All 5 tests fail on main and pass with the change. The existing register, password, invite, two-factor and login tests still pass (153). Full suite: 5,431 passed; the 2 failures (CurrencyAndBackupTest, MailLinkHostTest) fail the same way on main.

…login does

Only the client login page used the theme. Register, forgot-password,
reset-password, two-factor and invite hard-coded the starter blues
(#1a4d80, #337ab7, #405189) and ignored the uploaded logo, and
forgot-password, reset-password and invite read --card, --border and
--text, which nothing defined.

- client/auth/partials/theme-head: favicon, theme variables and the three
  variables those pages read, from the theme tokens.
- client/auth/partials/brand: the logo, or the shop's name in the theme
  colour. Register already showed the name and now shows the logo too.
- The brand colours go through --theme-primary / --theme-accent with the
  old values as fallbacks. Error reds are left alone.
- The four pages missing from the ThemeComposer list are added.

Fixes Panelica#458.
@Panelica
Panelica merged commit e71d7ee into Panelica:main Nov 18, 2026
1 check passed
@Panelica

Copy link
Copy Markdown
Owner

Merged, thank you.

This one conflicted with #468 in AppServiceProvider — both add to the same composer list. Resolved by keeping both sides (the four client auth views and the two admin ones); nothing else was touched.

All 5 tests red on 1.29.0, green after. Measured on the merge result: the full suite is green — 5463 passed in parallel (--exclude-group=serial, 4 processes) plus the 17 serial installer tests, 5 skipped, 0 failed.

@Panelica

Copy link
Copy Markdown
Owner

Released in 1.30.0, the stable channel, offered to every installation.

Gates on the tag and that package: full suite 5463 passed in parallel plus the 17 serial installer tests (0 failed, 5 skipped); 276 translation and parity tests green; the update lab 14 scenarios ALL GREEN; the real package updated the last stable (1.29.0 → 1.30.0, 13 checks) and the last beta (1.25.1-beta.1 → 1.30.0, 14 checks), each installed from its published package in the published runtime image with the signature checked by the key built into the application; the three uploaded assets re-downloaded and compared byte for byte before publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Client register, forgot-password, reset-password, invite and two-factor pages ignore the active theme colours and the uploaded logo

2 participants