Repository navigation
feat(tax): a notice for documents that carry no tax, set on the tax page (#449) - #471
Conversation
|
Merged, thank you — and closing #449 with it. Verified the escaping, since the notice goes into a document: All 5 tests red on 1.29.0, green after. Measured on the merge result: the full suite is green — 5463 passed in parallel ( |
|
Released in 1.30.0, the stable channel, offered to every installation. Gates on the tag and that package: full suite 5463 passed in parallel plus the 17 serial installer tests (0 failed, 5 skipped); 276 translation and parity tests green; the update lab 14 scenarios ALL GREEN; the real package updated the last stable (1.29.0 → 1.30.0, 13 checks) and the last beta (1.25.1-beta.1 → 1.30.0, 14 checks), each installed from its published package in the published runtime image with the signature checked by the key built into the application; the three uploaded assets re-downloaded and compared byte for byte before publishing. |
|
Thank you very much for implementing this feature so quickly! I've updated our WHOST installation to PNLCS 1.30.0 and tested the new tax exemption notice with the Austrian small business VAT exemption (§ 6 Abs. 1 Z 27 UStG 1994). Everything works as expected:
It's great to have this functionality built directly into PNLCS instead of maintaining custom Blade changes. Excellent work, and thank you again for the incredibly fast implementation! Best regards, |
Closes #449.
What was missing
A business under a small-business VAT exemption, such as Austria's § 6 Abs. 1 Z 27 UStG 1994 or Germany's § 19 UStG, charges no VAT and must say why on its invoices. PNLCS could already stop charging tax (the "Charge tax" switch on the tax page, #305), but it had nowhere to put the legal line. The reporter edited
client/cart/index.blade.phpandpdf/invoice.blade.phpby hand and has to redo that on every update.What changes
TaxExemptionNotice, up to 500 characters), under the two existing switches. Leave it empty and nothing changes anywhere.taxandtax2are both zero:{tax_notice}placeholder for uploaded templates, also added to the three sample templates indatabase/invoice-templates/.App\Support\TaxNotice. An invoice that charged tax never shows the notice, even if the field is filled in later.The text is read when the document is shown, not copied onto the invoice. That is how the company's own address and tax number already reach the PDF (
InvoicePdfService::companyDetails()). Copying the line onto every invoice would need a new column, so I left it out; it is easy to add if you would rather freeze it.What is not covered:
Tests
tests/Feature/TaxExemptionNoticeTest.php(5 tests) covers:{tax_notice}and on the customer's invoice page;All 5 fail on
mainand pass here.Full suite: 5431 passed, 3 skipped, 2 failed. The two failures (
CurrencyAndBackupTest,MailLinkHostTest) fail the same way onmainin my environment.