Skip to content

Teach the autonomy-override doubles the turn_request kwarg - #27

Closed
Parad0x-Labs wants to merge 1 commit into
mainfrom
mission/autonomy-override-signature
Closed

Parad0x-Labs wants to merge 1 commit into
mainfrom
mission/autonomy-override-signature

Conversation

@Parad0x-Labs

Copy link
Copy Markdown
Owner

What failed

tests/test_autonomy_override.py — 2 of 5 cases red in the main CI census (run 35570948370)
and every PR run since; deterministic locally:

  • test_run_once_puts_override_in_force_then_resets
  • test_run_once_resets_override_even_on_exception

Both with TypeError: fake_inner() got an unexpected keyword argument 'turn_request' at
core/agent_runtime/agent.py:1619.

Root cause

run_once forwards the served turn's request identity to _run_once_inner as a
turn_request keyword (present since the public root 78f818b; the real _run_once_inner
at agent.py:1842 takes it). The suite's two lifecycle doubles still carry the older
three-parameter signature (user_input, session_id_override, source_context), so the
doubles die with TypeError before the override-in-force / reset-on-exception assertions
can run. The suite landed with the public tree and never caught up.

Repair (test-only, one file)

The doubles accept turn_request=None. The override lifecycle under test — the composer's
auto in force during the turn, reset in finally, reset even on exception — is unchanged;
no assertion touched.

Validation

  • Target suite: 2 failed → 5 passed.
  • CI census count for this file: exactly these 2 (main 35570948370).
  • Neighbors (test_one_intent_one_declaration, test_operator_actions,
    test_git_command_gate): 73 passed together with the repaired suite.
  • ruff check . clean (pinned 0.16.7).

Base: main 8153a96. One file changed (tests/test_autonomy_override.py, +6/−2).

run_once forwards the served turn's request identity to _run_once_inner
as turn_request (agent.py:1619, present since the public root); the two
lifecycle doubles still had the older three-parameter signature and
died with TypeError before the override's in-force/reset assertions
could run. The doubles now accept the kwarg; the override lifecycle
under test is unchanged. 2 CI failures (main run 35570948370) ->
5 passed; execution-gate neighbors green.
@Parad0x-Labs
Parad0x-Labs deleted the mission/autonomy-override-signature branch September 23, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant