Teach the autonomy-override doubles the turn_request kwarg - #27
Closed
Parad0x-Labs wants to merge 1 commit into
Closed
Parad0x-Labs wants to merge 1 commit into
Parad0x-Labs wants to merge 1 commit into
Conversation
run_once forwards the served turn's request identity to _run_once_inner as turn_request (agent.py:1619, present since the public root); the two lifecycle doubles still had the older three-parameter signature and died with TypeError before the override's in-force/reset assertions could run. The doubles now accept the kwarg; the override lifecycle under test is unchanged. 2 CI failures (main run 35570948370) -> 5 passed; execution-gate neighbors green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
tests/test_autonomy_override.py— 2 of 5 cases red in the main CI census (run 35570948370)and every PR run since; deterministic locally:
test_run_once_puts_override_in_force_then_resetstest_run_once_resets_override_even_on_exceptionBoth with
TypeError: fake_inner() got an unexpected keyword argument 'turn_request'atcore/agent_runtime/agent.py:1619.Root cause
run_onceforwards the served turn's request identity to_run_once_inneras aturn_requestkeyword (present since the public root78f818b; the real_run_once_innerat agent.py:1842 takes it). The suite's two lifecycle doubles still carry the older
three-parameter signature (
user_input, session_id_override, source_context), so thedoubles die with
TypeErrorbefore the override-in-force / reset-on-exception assertionscan run. The suite landed with the public tree and never caught up.
Repair (test-only, one file)
The doubles accept
turn_request=None. The override lifecycle under test — the composer'sautoin force during the turn, reset infinally, reset even on exception — is unchanged;no assertion touched.
Validation
test_one_intent_one_declaration,test_operator_actions,test_git_command_gate): 73 passed together with the repaired suite.ruff check .clean (pinned 0.16.7).Base: main
8153a96. One file changed (tests/test_autonomy_override.py, +6/−2).