Accept the runtime_notice kwarg in the withheld-content gate double - #28
Closed
Parad0x-Labs wants to merge 1 commit into
Closed
Parad0x-Labs wants to merge 1 commit into
Parad0x-Labs wants to merge 1 commit into
Conversation
finalization calls gate_publishable_content with runtime_notice (the gated-publication seam); the suite's double predated the kwarg, so the gate crashed and finalization published UNGATED -- the exact corruption the suite pins, silently: with ungated bytes every demand reads satisfied and the withheld statement wrongly satisfies its slot. The double accepts the kwarg; every assertion is unchanged. 3 CI failures (main run 35570948370) -> 5 passed; the six grounding-publication neighbor suites run identically apart from two pre-existing conductor cases that fail the same on clean main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
tests/test_withheld_content_unsatisfies_its_slot.py— 3 of 5 cases red in the main CIcensus (run 35570948370) and every PR run since; deterministic locally:
test_a_withheld_statement_unsatisfies_the_slot_it_was_about—demand_satisfied2,expected 1
test_the_served_bytes_never_carry_the_withheld_statementtest_the_reader_is_told_which_slot_went_missingRoot cause
The suite's
_gatedouble forcore.grounding_publication.gate_publishable_contenthas thepre-
runtime_noticesignature.core.finalizationcalls the gate withruntime_notice=…; the double raisesTypeError, finalization logs "grounding publicationgate failed; publishing ungated" and falls back to UNGATED bytes — which is precisely the
corruption the suite exists to pin: with ungated bytes every demand reads satisfied, so the
withheld statement wrongly satisfies its slot (
demand_satisfied2 instead of 1). Thesuite was failing for the opposite of its purpose — the production accounting it checks is
correct once the gate actually runs.
Repair (test-only, one file, +5/−1)
The double accepts
runtime_notice=False. Every assertion is unchanged.Validation
nothing withheld).
gate_publishable_contentneighbor suites(
test_served_evidence_binding_p0,test_operator_class_new_wording_2026_09_07,test_final_answer_author_eligibility_p0,test_unsupported_current_claims_cannot_publish_m3,test_truth_boundaries_representation_and_execution,test_mixed_turn_knowledge_sibling_p1)plus the repaired file: 97 passed, 2 failed — the same two conductor cases fail
identically on clean main (stash-verified; pre-existing, untouched here).
ruff check .clean (pinned 0.16.7).Base: main
8153a96. One file changed.