Repository navigation
Vertical Coordinate Interpolators #3037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
75a20b6
initial vertical coordinate interpolator plumbing
wyatt-fluidnumerics 4e98ebc
implement UxLinearNodeLinearZf and corresponding Vertical coord inter…
wyatt-fluidnumerics adc20eb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b00c9d1
Add xgrid interpolators and testing
wyatt-fluidnumerics 7bebb28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a8a5de2
swap time indexing in uxinterpolators to be more compatable with wind…
wyatt-fluidnumerics dd5f01d
make all ux interpolators linear in time
wyatt-fluidnumerics c016552
Move vertical interpolator testing to its own file
wyatt-fluidnumerics 3cc828e
Add default z interpolator and linear in time interpolation testing f…
wyatt-fluidnumerics 2da08b7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6f5355e
Remove experimental warning on startup
wyatt-fluidnumerics 3850d9e
Merge branch 'vertical-coordinate-interpolators' of github.com:Parcel…
wyatt-fluidnumerics 24ecc04
Renamed tutorial and added vertical coord interpolator section
wyatt-fluidnumerics 012c0fe
Clear notebook output
wyatt-fluidnumerics 13aaeb3
minor changes
wyatt-fluidnumerics 87e87c3
add py:obj to tutorial interpolators
wyatt-fluidnumerics 71f206a
Merge branch 'main' into vertical-coordinate-interpolators
wyatt-fluidnumerics 4a0b6cc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cb13494
Added chunked cache array default for dask backed time varying z
wyatt-fluidnumerics 494f49f
Merge branch 'vertical-coordinate-interpolators' of github.com:Parcel…
wyatt-fluidnumerics 940f400
Added dimension transpose functions for time varying z to xgrid and u…
wyatt-fluidnumerics 401194b
More explicit error message on incorrect interpolator setting
wyatt-fluidnumerics 533f9f6
Removed WIP comments and reordered _search_time_varying_z args
wyatt-fluidnumerics 9c8e637
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 93fc6e0
Changed location of tutorial in toctree, changed relavent links in th…
wyatt-fluidnumerics 8664333
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fdde86e
Fix tutorial
wyatt-fluidnumerics ee169f8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 97a0bda
Move interpolator repr functions to _repr_utils
wyatt-fluidnumerics 4b6d64b
Merge branch 'vertical-coordinate-interpolators' of github.com:Parcel…
wyatt-fluidnumerics 752fe0a
Add docstring comment padding comment to _position_between_cell_centres
wyatt-fluidnumerics 7c88448
Add docstring to VerticalCoordinateInterpolator and x/uxgrid.z_inter_…
wyatt-fluidnumerics 6bcc9ec
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 06cda90
Changed deleted particles to use X in final tutrorial animation
wyatt-fluidnumerics afbfad2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e09d71a
Fix typing
wyatt-fluidnumerics 0d6493c
Merge branch 'main' into vertical-coordinate-interpolators
wyatt-fluidnumerics File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
295 changes: 263 additions & 32 deletions
295
...r_guide/fieldsets_sigma_coordinates.ipynb → ...ieldsets_time_varying_z_coordinates.ipynb
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on individual lines, so below some comments on the notebook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in fdde86e
It is expected that the particles don't move horizontally, the goal here is to show that when using a discontinuous interpolation scheme you can get spurious particle deletion for near surface particles when they grid moves around them. I changed the animations to change the color of the particles when they are deleted and then include a legend for the animation. Let me know what you think, it is possible that it is best to just remove the code blocks in the "Choosing how z is interpolated" section entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I only now realise that these particles are deleted. Perhaps change them from a circle to a cross when they are deleted? Would that be even clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's a good idea. Changed in 06cda90