Repository navigation
Cleanup TODOs - #3068
Merged
Merged
Cleanup TODOs#3068
Conversation
The lon, lat, depth are needed in the codebase - the z4d and gtype not
Still leftover from before we had convert functions
I don't think the code becomes clearer if we constantly have to use field.model.grid, instead of field.grid. I actually like the current implementation
As we keep grid.depth (perhaps to be renamed to grid.z)
Member
Author
|
@wyatt-fluidnumerics, no rush for this review. Perhaps easiest to review it by commit, instead of by file? |
wyatt-fluidnumerics
approved these changes
Nov 18, 2026
| # raise ValueError( | ||
| # f"Expected `model` to be a Parcels ModelData object. Got {type(model)}." | ||
| # ) | ||
| from parcels._core.model import ModelData |
Contributor
There was a problem hiding this comment.
Does this import belong here or at the top of the file?
Member
Author
There was a problem hiding this comment.
I agree this is not pretty, but otherwise I got a circular import. Do you know a better solution?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up many of the TODOs that were added to the codebase during the intensive-development phase (pre-v4-release).
A handful of TODOs remain - these are a bit larger and better to have their own PRs
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
N/A