Skip to content

Cleanup TODOs - #3068

Merged
erikvansebille merged 21 commits into
Parcels-code:mainfrom
erikvansebille:cleanup_TODOs
Nov 19, 2026
Merged

erikvansebille merged 21 commits into
Parcels-code:mainfrom
erikvansebille:cleanup_TODOs

Conversation

@erikvansebille

Copy link
Copy Markdown
Member

Description

This PR cleans up many of the TODOs that were added to the codebase during the intensive-development phase (pre-v4-release).

A handful of TODOs remain - these are a bit larger and better to have their own PRs

Checklist

  • Tests added
  • This PR targets the correct branch (main for normal development, v3-support for v3 support)

AI Disclosure

N/A

@erikvansebille

Copy link
Copy Markdown
Member Author

@wyatt-fluidnumerics, no rush for this review. Perhaps easiest to review it by commit, instead of by file?

@wyatt-fluidnumerics wyatt-fluidnumerics left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just the one question below! No worries, I'd been going through since we got off the meeting.

# raise ValueError(
# f"Expected `model` to be a Parcels ModelData object. Got {type(model)}."
# )
from parcels._core.model import ModelData

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this import belong here or at the top of the file?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is not pretty, but otherwise I got a circular import. Do you know a better solution?

@erikvansebille
erikvansebille enabled auto-merge (squash) November 19, 2026 09:48
@erikvansebille
erikvansebille merged commit 6befcc7 into Parcels-code:main Nov 19, 2026
20 of 21 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Parcels development Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants