Repository navigation
fix: escape closes a dialog from its close button, view cube focus ring, ? for shortcuts - #472
Merged
Merged
Conversation
…ng, ? for shortcuts U-03: React Aria's tooltip took the Escape on the document in the capture phase while the focused close button showed it; the window now hears it first. U-12: the view cube's faces show a focus ring. U-20: ? outside a text field opens Settings > Shortcuts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usability offensive group 4 (docs/usability-2026-11.md).
?outside a text field opens Settings › Shortcuts (listed there too). E2E.Before (Escape pressed, settings stay open):
After: the same Escape closes the settings (E2E
the settings open with Ctrl+comma …).Checked: typecheck, eslint, unit tests, E2E settings, first start, assistant status.
🤖 Generated with Claude Code