Skip to content

fix: escape closes a dialog from its close button, view cube focus ring, ? for shortcuts - #472

Merged
ManuelStaggl merged 2 commits into
mainfrom
fix/usability-keyboard
Nov 16, 2026
Merged

ManuelStaggl merged 2 commits into
mainfrom
fix/usability-keyboard

Conversation

@ManuelStaggl

Copy link
Copy Markdown
Collaborator

Usability offensive group 4 (docs/usability-2026-11.md).

  • U-03 With the focus on a dialog's close button, Escape did nothing: the button shows its tooltip ("Close · Esc"), and React Aria's tooltip listens for Escape on the document in the capture phase and stops it, so the dialog never saw it. The close button now hears Escape on the window first and closes its dialog. E2E: settings close with Escape from the focused X.
  • U-12 The view cube's faces get a visible focus ring (WCAG 2.4.7). The timeline's target-size hits from axe are the step half under the scroll edge or the bar's handle, not a too-small button (24 px); unchanged.
  • U-20 ? outside a text field opens Settings › Shortcuts (listed there too). E2E.

Before (Escape pressed, settings stay open): U-03
After: the same Escape closes the settings (E2E the settings open with Ctrl+comma …).

Checked: typecheck, eslint, unit tests, E2E settings, first start, assistant status.

🤖 Generated with Claude Code

ManuelStaggl and others added 2 commits November 16, 2026 08:48
…ng, ? for shortcuts

U-03: React Aria's tooltip took the Escape on the document in the
capture phase while the focused close button showed it; the window
now hears it first. U-12: the view cube's faces show a focus ring.
U-20: ? outside a text field opens Settings > Shortcuts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ManuelStaggl
ManuelStaggl merged commit 6ae0655 into main Nov 16, 2026
10 checks passed
@ManuelStaggl
ManuelStaggl deleted the fix/usability-keyboard branch November 16, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant