API endpoints for storing/retrieving license metadata#5631
Open
PhilBastian wants to merge 10 commits into
Open
API endpoints for storing/retrieving license metadata#5631PhilBastian wants to merge 10 commits into
PhilBastian wants to merge 10 commits into
Conversation
mikeminutillo
approved these changes
Jul 22, 2026
| using var fileStream = file.OpenReadStream(); | ||
| using var fileStreamReader = new StreamReader(fileStream); | ||
| var compressed = await fileStreamReader.ReadToEndAsync(cancellationToken); | ||
| var compressedData = Convert.FromBase64String(compressed); |
Member
There was a problem hiding this comment.
We probably don't need the Base64 conversion when we aren't embedding details in the license file.
That means we could hook the BrotliStream directly to the fileStream.
It may be worth trying to pass that into the deserializer as well. That way we avoid creating big in-memory string objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also change max monthly usage to average monthly usage