Add a Radius Jewel Finder - #10057
Draft
mcagnion wants to merge 8 commits into
Draft
Conversation
Add the Tree tab Radius Jewel Finder UI, data catalog, computation helpers, and manifest entries.
Cover socket discovery, variant handling, ranking, apply safety, occupied sockets, and state restoration for the Radius Jewel Finder.
Default variant-aware jewel types to All variants, and constrain compute/find paths when a specific variant is selected.
Adapt the finder to the current per-mod Foulborn data model, preserve selected variants through Find and Compute, and cover the regression paths. Excludes Foulborn Might of the Meek until its radius is modelled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Finding a good socket for a radius jewel currently means manually comparing each socket, its passive radius, and the effect on the build.
This adds Find Radius Jewel to the Tree tab. Select a jewel family—or
All jewels—and PoB ranks the supported jewel and socket combinations against the chosen stat. Results can be previewed and applied directly to the build.Use the panel to select the jewel family and comparison stat, then run the calculation. The result list shows the gain, percentage gain and gain per passive point; selecting a row shows the affected socket, passives and any Foulborn mutation.
The finder covers the radius jewels it can evaluate generically, including applicable Foulborn variants. Timeless Jewels continue to use their dedicated finder; conversion jewels such as Cold Steel and Fireborn are outside this tool's scope. Foulborn Might of the Meek is not included until its radius is modeled.
Steps taken to verify a working solution:
./scripts/test-fast.sh --brief(484 tests, no failures).All jewelsview.Screenshots