Add support for select pseudo stats in trader weights - #10085
Draft
vaisest wants to merge 1 commit into
Draft
Conversation
vaisest
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This PR tries to solve the problem of having a lot of duplicate stats in the trader weights, which is a pretty big problem in PoE1 since there is an insane amount of mods. This is done by adding hardcoded mappings for single resist and attribute stats, and by banning the equivalent hybrid stats.
This already does quite a lot, but I think it would be a good idea to add more things since duplicating e.g. enchant + implicit + explicit a bit silly. However, there are some problems there. Firstly any overlap between different pseudo mods will inflate the result score. For example pseudo life + pseudo strength is not correct. Secondly, some texts don't match up. For example pseudo incr phys % includes local phys %, but pseudo flat phys does not (it's in phys to attacks). Thirdly there are garbage mods like the conditional eldritch mods which would count in pseudo stats.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: