Skip to content

Add support for chance to detonate mines an additional time - #10086

Open
MatthewSbar wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
MatthewSbar:mine-additional-detonation-chance
Open

Add support for chance to detonate mines an additional time#10086
MatthewSbar wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
MatthewSbar:mine-additional-detonation-chance

Conversation

@MatthewSbar

@MatthewSbar MatthewSbar commented Aug 1, 2026

Copy link
Copy Markdown

This is my first contribution so hopefully I did everything right 🤷

Description of the problem being solved:

"Mines have a #% chance to be Detonated an Additional Time" (Expert Sabotage medium cluster notable, the Careful Handling wheel, and crucible weapon mods) was unrecognised. This PR adds a MineAdditionalDetonationChance modifier, capped at 100% (my understanding is that additional detonations isn't re-rolled on success or "surpassing" in poe2 terms) and applied as an average DPS multiplier via skillData.dpsMultiplier. Shown as "Extra Deton. Chance" in the Calcs tab Mines section with a breakdown.

Steps taken to verify a working solution:

  • New regression test in TestOffence_spec.lua: 10% chance gives 1.10x TotalDPS on Stormblast Mine, stacking is additive and capped at 100% (2.0x), and non-mine skills are unaffected
  • Verified damage numbers are logical using my own build before/after this PR

Link to a build that showcases this PR:

Here's my own build this league
https://pobb.in/JZyvthjUn70B

Before screenshot:

image image

After screenshot:

image image

@MatthewSbar
MatthewSbar marked this pull request as ready for review August 1, 2026 15:59
@MatthewSbar MatthewSbar changed the title Add mine detonation chance Add support for chance to detonate mines an additional time Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant