Add support for chance to detonate mines an additional time - #10086
Open
MatthewSbar wants to merge 1 commit into
Open
Add support for chance to detonate mines an additional time#10086MatthewSbar wants to merge 1 commit into
MatthewSbar wants to merge 1 commit into
Conversation
MatthewSbar
marked this pull request as ready for review
August 1, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first contribution so hopefully I did everything right 🤷
Description of the problem being solved:
"Mines have a #% chance to be Detonated an Additional Time" (Expert Sabotage medium cluster notable, the Careful Handling wheel, and crucible weapon mods) was unrecognised. This PR adds a MineAdditionalDetonationChance modifier, capped at 100% (my understanding is that additional detonations isn't re-rolled on success or "surpassing" in poe2 terms) and applied as an average DPS multiplier via skillData.dpsMultiplier. Shown as "Extra Deton. Chance" in the Calcs tab Mines section with a breakdown.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Here's my own build this league
https://pobb.in/JZyvthjUn70B
Before screenshot:
After screenshot: