Repository navigation
docs: correct scheduled-routines.md's trigger tool-access claim - #668
Conversation
The doc claimed both cloud triggers run with tools limited to Bash, Read, Glob, Grep, Edit, Write, TodoWrite and no MCP tools, calling that the mechanical half of "provably excludes Layer 4". Querying the live trigger definitions (mcp__Claude_Code_Remote__get_trigger/list_triggers) shows neither carries an allowed_tools restriction: both have the full session tool surface plus nine MCP connectors with empty permitted_tools (unrestricted). There is no tool-level exclusion of Layer 4 — Bash alone can invoke it. The hermetic guarantee is enforced by the routine prompt's HARD RULES, not by tool access control. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TgrUL5Je2LLNyxN61gE9qt
|
Review verdict: approve (docs-only) Reviewed the diff ( Factual accuracy: The new text matches the live trigger reality described in the issue: the old claim of a Secrets/sensitive data: None introduced. The content added is connector names, a HARD RULES restatement, and a dated correction note — no tokens, keys, or credentials. Scope: Docs-only, single file, no unrelated changes bundled in. Prose/Markdown: Reads cleanly; bold/code-span markup is balanced, the dated correction note is clearly flagged, and links/formatting are consistent with the rest of the file. No changes requested. Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea247bcf24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `Artifact`, `Workflow`, `ToolSearch`, `ScheduleWakeup`, `SendUserFile`, `Skill`, | ||
| `ListAgents`, the `github` MCP server, plus nine more MCP connectors (`Google_Calendar`, | ||
| `Slack`, `Gmail`, `Google_Drive`, `Figma`, `Vercel`, `Linear`, `Claude_Code_Remote`, | ||
| `Format`) each with an empty `permitted_tools` (i.e. unrestricted). There is **no |
There was a problem hiding this comment.
Verify connector access before calling it unrestricted
An empty permitted_tools field does not by itself establish that every connector tool is callable; current remote-trigger behavior has also treated [] as “nothing permitted,” and attached connectors can remain filtered or approval-gated (upstream reproduction). The trigger definitions therefore support saying these connectors are attached, but not that the routines carry their unrestricted runtime tool surface without verifying a fired session. This distinction matters when this section is used as the routine's access/threat inventory.
AGENTS.md reference: AGENTS.md:L154-L154
Useful? React with 👍 / 👎.
| "never" in `AGENTS.md`, not a tool-level allowlist. Treat "hermetic" as a prompted | ||
| behavior, not a provable one, until/unless the trigger's `mcp_connections` are | ||
| actually pared down. Manage the triggers at https://claude.ai/code/routines. |
There was a problem hiding this comment.
Keep hermeticity conditional on blocking the Bash paths
The until/unless qualification implies that paring down mcp_connections would make hermeticity mechanically provable, but the preceding sentence correctly notes that Bash alone can launch layer4cdp, dev-rig, or the sweeps. Even with every MCP connector removed, the unattended routine retains the exact real-host path forbidden by the repository policy, so mechanical exclusion must also block those Bash executions or their required capabilities rather than treating connector removal as sufficient.
AGENTS.md reference: AGENTS.md:L49-L49
Useful? React with 👍 / 👎.
Why
doc/scheduled-routines.mdclaimed both scheduled triggers (weekly maintenance, monthly audit) run with tools "limited toBash, Read, Glob, Grep, Edit, Write, TodoWrite— no browser or MCP tools," and called this "the mechanical half of 'provably excludes Layer 4'." Issue #654 flagged that this session (and prior routine runs) observably had GitHub MCP access the doc said shouldn't exist, but couldn't pull the trigger's actual config to pin down the real list.This run has
mcp__Claude_Code_Remote__get_trigger/list_triggersavailable, so it queried both trigger IDs directly.What
Ground truth from the live trigger definitions: neither
trig_01VgDQW3FWV5Ln4HUutsHBRt(weekly) nortrig_01RoxWz7WbEqtHxe4y62A99M(monthly) carries anallowed_toolsrestriction at all. Both have:Bash,Agent,Artifact,Workflow,ToolSearch,ScheduleWakeup,SendUserFile,Skill,ListAgents, thegithubMCP server, …)Google_Calendar,Slack,Gmail,Google_Drive,Figma,Vercel,Linear,Claude_Code_Remote,Format), each with an emptypermitted_tools(i.e. unrestricted)So the doc's specific tool list and its "no MCP tools" claim were both wrong, and the "mechanical half of 'provably excludes Layer 4'" framing doesn't hold —
Bashalone is sufficient to invokelayer4cdp/dev-rig/the sweeps. Updateddoc/scheduled-routines.mdto state this accurately: the hermetic/no-Layer-4 guarantee rests entirely on the routine prompt's HARD RULES (the same trust basis as every other "never" inAGENTS.md), not on a tool allowlist.No code changes; docs only.
Verification
mcp__Claude_Code_Remote__get_triggerfor both IDs andlist_triggersfor cross-check — no secrets in the output, only connector names/UUIDs and the stored prompt text (already public in this doc).git diffreviewed; change is confined todoc/scheduled-routines.md.Closes #654.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TgrUL5Je2LLNyxN61gE9qt
Generated by Claude Code