Repository navigation
fix(security): accept the reviewed P5 fixtures under the squash-merge commit - #225
Merged
Merged
Conversation
… commit #222 was squash-merged, so the two reviewed false positives reappear under eadee8d instead of the PR commit eea5445. The credential scan therefore failed on main and on every open PR: - a gVisor binary digest in experiments/linux-execution/native-config.ts; - the example.invalid URL fixture in scripts/integration/fixtures/web-contract-compatibility.json. Add the same entries with the merge commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The credential scan has failed on
mainsince #222, and on every open PR (#220, #221, #224 and the docs PR), because CI scans all fetched refs.The cause is the squash merge.
scripts/check-credential-findings.tsaccepts reviewed false positives by exact commit, file, line and digest. #222's two reviewed fixtures were recorded under its PR commiteea54455, but the squash merge rewrote them aseadee8d5, so they no longer matched:experiments/linux-execution/native-config.ts:16: a gVisor binary SHA-256 that the SentryToken detector misreads;scripts/integration/fixtures/web-contract-compatibility.json:16842: ahttps://user:…@example.invalidfixture URL.This adds the same entries under the merge commit. No value, digest or file changes.
Follow-up for whoever owns the scan: commit-pinned entries break on every squash merge. Either record the merge commit after merging, or merge these PRs with a merge commit.
Checks
a175b5a2onmain: 2 findings, exactly the two above.node scripts/check-credential-findings.ts <results> 183with this change: "Credential scan passed; 2 exact historical fixture(s)."node --test scripts/check-credential-findings.test.ts: 3 pass.npm run security:config-check: passed.🤖 Generated with Claude Code