Skip to content

fix(cli): use packed CLI in smoke tests - #423

Merged
maxnorm merged 1 commit into
Perfect-Abstractions:mainfrom
maxnorm:feat/deploy
Nov 17, 2026
Merged

maxnorm merged 1 commit into
Perfect-Abstractions:mainfrom
maxnorm:feat/deploy

Conversation

@maxnorm

@maxnorm maxnorm commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Changes Made

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Existing tests pass - Run tests to be sure existing tests pass.

  • New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

  • Changesets — If this PR changes publishable packages (src/, cli/), changeset-bot will comment if a release note might be needed. You can add one when convenient or defer to maintainers.

Make sure to follow the contributing guidelines.

Additional Notes

@changeset-bot

changeset-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 157ac3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Nov 17, 2026

Copy link
Copy Markdown

👷 Deploy request for compose-diamonds pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 157ac3f

@maxnorm
maxnorm marked this pull request as ready for review November 17, 2026 02:38
@github-actions

Copy link
Copy Markdown
Contributor

CLI Coverage

Commit: 157ac3f

Metric Coverage Covered/Total
Lines 81% 3854/4774
Functions 84% 776/921
Branches 71% 2457/3484

@maxnorm
maxnorm merged commit 75158a1 into Perfect-Abstractions:main Nov 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant