Buffer underflow, fix ipv6 favourism and example update - #35
Open
brostosjoined wants to merge 8 commits into
Open
Buffer underflow, fix ipv6 favourism and example update#35brostosjoined wants to merge 8 commits into
brostosjoined wants to merge 8 commits into
Conversation
Author
|
The script somehow favours ipv6 port even when the protocol is set to ipv4 so ports must be same |
Author
20:17:18 [PieRakNet - INFO] - Server initialized.
20:17:18 [PieRakNet - INFO] - Server started on 0.0.0.0:19132! (IPv4)
Traceback (most recent call last):
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\EXAMPLE.py", line 43, in <module>
server.main()
~~~~~~~~~~~^^
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\EXAMPLE.py", line 36, in main
raise(e)
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\EXAMPLE.py", line 30, in main
self.server.start()
~~~~~~~~~~~~~~~~~^^
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\pieraknet\server.py", line 132, in start
self.handle_data(data, client)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\pieraknet\server.py", line 147, in handle_data
connection.handle(data)
~~~~~~~~~~~~~~~~~^^^^^^
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\pieraknet\connection.py", line 49, in handle
handler(data, self.server, self)
~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\pieraknet\handlers\frame_set.py", line 10, in handle
frame_set_packet.decode(data)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\pieraknet\packets\frame_set.py", line 23, in decode
frame = self.decode_frame(buffer)
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\pieraknet\packets\frame_set.py", line 44, in decode_frame
frame['reliable_frame_index'] = buffer.read_uint24le()
~~~~~~~~~~~~~~~~~~~~^^
File "c:\Users\Brostos\Desktop\inventory\Games\PieRakNet-main\pieraknet\buffer.py", line 169, in read_uint24le
return struct.unpack("<I", uint24le)[0]
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
struct.error: unpack requires a buffer of 4 bytes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.