ci: move off Node 20 actions (checkout v7, setup-dotnet v6) - #7
Merged
Conversation
actions/checkout@v4 and actions/setup-dotnet@v4 both run on Node 20, which GitHub deprecated: the runner already force-runs them on Node 24 and annotates every job with a warning. Force-running is a grace period, not a contract -- when it ends these steps fail rather than warn. Both majors are input-compatible with what this repo passes (fetch-depth, dotnet-version), so the bump is version-only. checkout v7's one breaking change blocks fork-PR checkout under `pull_request_target` and `workflow_run`. Neither workflow uses those triggers -- ci.yml is push + plain `pull_request`, release.yml is a `v*` tag push -- so nothing here is affected. setup-dotnet v5.4 added strict `sdk.version` validation for global.json when rollForward is set; this repo has no global.json, so that path is never taken. NuGet/login stays at v1: v1 already tracks the newest release (v1.2.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
actions/checkout@v4andactions/setup-dotnet@v4run on Node 20, which GitHub deprecated. The runner already force-runs them on Node 24 and annotates every job with a warning. Force-running is a grace period, not a contract — when it ends, these steps fail rather than warn.What
actions/checkoutv4v7actions/setup-dotnetv4v6NuGet/loginv1v1(unchanged)v1Both majors are input-compatible with what this repo passes (
fetch-depth,dotnet-version), so this is version-only — no workflow logic changed.Breaking changes checked, none apply
pull_request_targetandworkflow_run. Neither workflow uses those triggers —ci.ymlispush+ plainpull_request,release.ymlis av*tag push.sdk.versionvalidation forglobal.jsonwhenrollForwardis set. This repo has noglobal.json.Verification
CI on this PR is the test:
build-test (ubuntu-latest),build-test (windows-latest)andpack-and-verifyall exercise the bumped steps, and the Node 20 deprecation annotation should be gone from the run.release.ymlis tag-triggered, so its bump cannot be exercised by this PR. It changed identically toci.yml's and shares the same two actions and inputs.