Skip to content

fix(github): point GitHub services at the renamed repo - #2827

Closed
PonceGL wants to merge 1 commit into
PixelPlayerHQ:masterfrom
PonceGL:chore/p8-github-announcement-repo-rename
Closed

PonceGL wants to merge 1 commit into
PixelPlayerHQ:masterfrom
PonceGL:chore/p8-github-announcement-repo-rename

Conversation

@PonceGL

@PonceGL PonceGL commented Sep 10, 2026

Copy link
Copy Markdown

What

GitHubAnnouncementPropertiesService.fetchPlayStoreAnnouncement() defaulted
to owner=theovilardo, repo=PixelPlay — the project's name before the
rename to PixelPlayerHQ/PixelPlayer. One of the small independent fixes
listed in #2813.

It works today only because raw.githubusercontent.com still resolves the
old path (verified: both URLs return identical content, same etag) — a
silent dependency on nobody claiming the old name.

Change

Points the defaults at the real repo. Single caller (MainActivity.kt) uses
no arguments, so that's the only thing that needed to change there.

A self-review pass (before this PR went up) found the identical problem in
the sibling GitHubContributorService.fetchContributors(), same
owner/repo defaults, powering the About screen's contributor list
(also called with no arguments) — not named in the original plan, but the
same bug. Confirmed empirically that this one is worse than the announcement
case: unlike the raw-content path, api.github.com/repos/theovilardo/PixelPlay
returns an actual HTTP 301, not a silent 200. Fixed with the same
one-line-per-default change.

Testing

No test added in either file — this predates a separate, unmerged branch
that genericizes GitHubAnnouncementPropertiesService in a way that makes
it testable without hitting real network; redoing that refactor here would
duplicate that branch's own scope, and GitHubContributorService has no
equivalent seam at all. Nothing to assert about a default string value
without one.

assembleDebug succeeds, full JVM baseline unaffected (5 pre-existing
failures, none new).

fetchPlayStoreAnnouncement() defaulted to owner=theovilardo,
repo=PixelPlay — the project's name before the rename to
PixelPlayerHQ/PixelPlayer. Works today only because
raw.githubusercontent.com still resolves the old path (verified: both
URLs return identical content, same etag) — a silent dependency on
nobody claiming the old name.

Points the defaults at the real repo. Single caller
(MainActivity.kt:758) uses no arguments, so this is the only thing
that needed to change there.

Self-review (code-review skill) found the identical problem in the
sibling GitHubContributorService.fetchContributors(), same
owner/repo defaults, powering the About screen's contributor list
(AboutScreen.kt:202, also called with no arguments) — not named in
the original plan, but the same bug. Confirmed empirically: unlike
the raw-content case, api.github.com/repos/theovilardo/PixelPlay
returns an actual HTTP 301, not a silent 200 — one redirect hop this
fix now removes entirely rather than leaving it to keep working by
GitHub's grace. Fixed with the same one-line-per-default change.

No test added in either file: this predates P.9's genericization of
GitHubAnnouncementPropertiesService (fetchRawProperties, separate
branch, unmerged) which is what makes that service testable without
hitting real network — redoing that refactor here would duplicate
P.9's own scope, and GitHubContributorService has no equivalent seam
at all. Nothing to assert about a default string value without one.

Baseline: 5 pre-existing failures, none new. assembleDebug succeeds.
@PonceGL

PonceGL commented Sep 10, 2026

Copy link
Copy Markdown
Author

Closing for now — reorganizing how this work is staged. It'll go through our fork first and we'll propose it upstream again, possibly bundled differently, once the larger feature it's part of is further along. Not a rejection, just a process change on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant