Repository navigation
Conversation
slawwan
marked this pull request as ready for review
October 6, 2026 14:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_try_advisory_lockis called without a timeout. If the connection dies silently while the guard waits for the lock (e.g. a standby replica or a new pod during a rolling update), the guard hangs forever and never acquires the lock.The fix adds
acquire_timeout(5 s by default) for each lock acquisition attempt. On timeout:fetchvalraisesTimeoutError, asyncpg sends a CancelRequest for the query over a separate connection;TimeoutErrortraceback;reconnect_delay, the same way as on any other connection failure;run(),funcis never started without the lock.If the server granted the lock but the response was lost, the lock stays with the old session until the session ends. Closing such a connection reliably depends on MagicStack/asyncpg#1361.
Tests:
test_acquire_lock_after_silent_disruption_while_waitingfails onmain, passes with the fix;test_log_failed_lock_acquisition_attemptcovers the warning.