Repository navigation
Distortion on each test - #1554
Merged
Merged
Conversation
This was referenced Oct 21, 2026
Merged
Gin890
force-pushed
the
distortion-on-each-test
branch
2 times, most recently
from
October 29, 2026 05:42
818c7fe to
baa108f
Compare
Gin890
marked this pull request as ready for review
October 29, 2026 06:10
Mysticial
approved these changes
Oct 30, 2026
Each test that loads test images now derives from ImageUnitTest and implements run_on_images(), so it also runs on re-colored images when the tests run with --augment-color-distortions. The tests now keep only the relative image paths, in ImageUnitTest. Tests that read golden files or parse the file name build the path from image_paths(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Otherwise the distortion runs overwrite the golden files with the results on re-colored images. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gin890
force-pushed
the
distortion-on-each-test
branch
from
October 31, 2026 02:01
baa108f to
003776e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up #1553, also change each unit test to use the distortion feature.