Skip to content

Remove compile-verified unnecessary includes #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mysticial merged 4 commits into from
Oct 29, 2026
Merged

Remove compile-verified unnecessary includes #1766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32da598
Remove compile-verified unnecessary includes
pa-devbot Oct 29, 2026
e5bb715
Merge remote-tracking branch 'origin/main' into compile-verified-incl…
pa-devbot Oct 29, 2026
2a14041
Re-verify removals against all platforms; keep only statically-safe ones
pa-devbot Oct 29, 2026
ee2837a
Restore QPermissions and QApplication in SetupSettings.cpp
pa-devbot Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Common/Cpp/CpuUtilization/CpuUtilization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include "CpuUtilization.h"


#if _WIN32
Expand Down
1 change: 0 additions & 1 deletion Common/Cpp/Hardware/Hardware.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/
#include "Common/Cpp/CpuId/CpuId.h"
#include "Hardware.h"

#if _M_IX86 || _M_X64 || __i386__ || __x86_64__
#include "Hardware_x86.tpp"
Expand Down
1 change: 0 additions & 1 deletion Common/Cpp/Options/CheckboxDropdownOption.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include "CheckboxDropdownOption.h"

namespace PokemonAutomation{

Expand Down
1 change: 0 additions & 1 deletion Common/Cpp/SerialConnection/SerialConnection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <iostream>
#include "Common/Cpp/Time.h"
#include "Common/Cpp/Concurrency/Mutex.h"
#include "SerialConnection.h"

namespace PokemonAutomation{

Expand Down
1 change: 0 additions & 1 deletion Common/Cpp/Sockets/ClientSocket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include "ClientSocket.h"

namespace PokemonAutomation{

Expand Down
1 change: 0 additions & 1 deletion Common/Qt/Options/ButtonWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <iostream>
#include <QHBoxLayout>
#include <QLabel>
#include <QCheckBox>
#include "ButtonWidget.h"

//using std::cout;
Expand Down
1 change: 0 additions & 1 deletion Common/Qt/Options/DateWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <QHBoxLayout>
#include <QLabel>
#include <QDateEdit>
#include "DateWidget.h"

//#include <iostream>
Expand Down
1 change: 0 additions & 1 deletion Common/Qt/Options/EditableTableWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <QFileDialog>
#include <QVBoxLayout>
#include <QHeaderView>
#include <QScrollBar>
#include <QLabel>
#include <QPushButton>
#include <QMessageBox>
Expand Down
2 changes: 0 additions & 2 deletions Common/Qt/Options/StaticTableWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@
#include <QFileDialog>
#include <QVBoxLayout>
#include <QHeaderView>
#include <QScrollBar>
#include <QLabel>
#include <QPushButton>
#include <QTableWidget>
#include "Common/Cpp/Json/JsonValue.h"
#include "Common/Qt/AutoHeightTable.h"
#include "StaticTableWidget.h"
Expand Down
1 change: 0 additions & 1 deletion Common/Qt/Options/TextEditWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include <QStyle>
#include <QVBoxLayout>
#include <QLabel>
#include <QTextEdit>
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommandLine/CommandLine_Main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "Common/Cpp/Logging/LastLogTracker.h"
#include "Common/Cpp/Logging/FileLogger.h"
#include "Common/Cpp/Logging/GlobalLogger.h"
#include "CommonFramework/Globals.h"
#include "CommonFramework/Logging/Logger.h"
// #include "CommonFramework/Logging/OutputRedirector.h"
#include "CommonFramework/Tools/GlobalThreadPools.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/AudioPipeline/AudioInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include "Common/Cpp/Containers/Pimpl.tpp"
#include "Kernels/AudioPipeline/Kernels_AudioPipeline.h"
#include "CommonFramework/Logging/Logger.h"
#include "CommonFramework/AudioPipeline/AudioPipelineOptions.h"
#include "AudioInfo.h"

//#include <iostream>
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/AudioPipeline/AudioSourceDescriptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include "AudioSourceDescriptor.h"

namespace PokemonAutomation{

Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/AudioPipeline/Backends/AudioPassthroughPairQt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "Kernels/AudioPipeline/Kernels_WorkingAudio2RawAudio.h"
#include "Kernels/AudioPipeline/Kernels_WorkingAudio2WorkingAudio.h"
#include "CommonFramework/GlobalSettingsPanel.h"
#include "CommonFramework/AudioPipeline/AudioPipelineOptions.h"
#include "CommonFramework/AudioPipeline/Tools/AudioFormatUtils.h"
#include "CommonFramework/AudioPipeline/Tools/ChannelMixer.h"
#include "CommonFramework/AudioPipeline/AudioSource.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/AudioPipeline/UI/AudioSelectorWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include <QAudio>
#include <QHBoxLayout>
#include <QLabel>
#include <QComboBox>
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/Environment/Environment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include "Environment.h"

#if _WIN32
#include "Environment_Windows.tpp"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/GlobalSettingsPanel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "Common/Cpp/Json/JsonArray.h"
#include "Common/Cpp/Json/JsonObject.h"
#include "Common/Cpp/Options/KeyboardLayoutOption.h"
#include "CommonFramework/Globals.h"
#include "CommonFramework/StaticGlobals.h"
#include "CommonFramework/GlobalAutoPaths.h"
#include "CommonFramework/Logging/Logger.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/Logging/LoggerWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include <QCoreApplication>
#include <QTimer>
#include <QMenuBar>
#include "Common/Cpp/Logging/LastLogTracker.h"
Expand Down
2 changes: 0 additions & 2 deletions SerialPrograms/Source/CommonFramework/Main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#include <iostream>
//#include <QTextStream>
#include <QApplication>
#include <QMessageBox>
#include "Common/Cpp/Logging/LastLogTracker.h"
#include "Common/Cpp/Logging/FileLogger.h"
#include "Common/Cpp/Logging/GlobalLogger.h"
Expand Down Expand Up @@ -39,7 +38,6 @@
#include "Startup/SetupSettings.h"
#include "Startup/NewVersionCheck.h"
#include "Windows/MainWindow.h"
#include "Globals.h"
#include "GlobalSettingsPanel.h"
#include "GlobalServices.h"
#include "PersistentSettings.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/Notifications/SenderNotificationTable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include "SenderNotificationTable.h"

namespace PokemonAutomation{

Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/Options/NestedBoxDrawOption.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include "CommonFramework/VideoPipeline/VideoOverlayScopes.h"
#include "NestedBoxDrawOption.h"

//#include <iostream>
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/Options/QtWidget/LabelCellWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*/

#include <QHBoxLayout>
#include <QFrame>
#include <QLabel>
#include "CommonFramework/ImageTypes/ImageRGB32_Qt.h"
#include "LabelCellWidget.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/Panels/UI/PanelElements.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include <QPushButton>
#include "Common/Cpp/ColoredText.h"
#include "Common/Qt/Options/ConfigWidget.h"
#include "CommonFramework/Globals.h"
#include "CommonFramework/Panels/PanelSession.h"
#include "CommonFramework/ProgramSession.h"
#include "GameConsole/ConsoleProgram.h"
Expand Down
3 changes: 0 additions & 3 deletions SerialPrograms/Source/CommonFramework/Panels/UI/PanelWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
*
*/

#include <QVBoxLayout>
#include <QGroupBox>
#include <QLabel>
#include "Common/Qt/CollapsibleGroupBox.h"
#include "CommonFramework/Panels/PanelDescriptor.h"
#include "CommonFramework/Panels/PanelSession.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/ResourceDownload/ProgramResourceDownloadWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*/

#include <QMessageBox>
#include <QEventLoop>
#include "CommonFramework/ProgramSession.h"
#include "ProgramResourceDownloadWidget.h"

Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/VideoPipeline/Backends/CameraImplementations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include <QtGlobal>
//#include "Common/Cpp/PrettyPrint.h"
#include "CommonFramework/StaticGlobals.h"
#include "CommonFramework/Globals.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/VideoPipeline/Backends/CameraWidgetQt6.5.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <QCamera>
#include <QVideoSink>
#include <QImageCapture>
#include "Common/Qt/Redispatch.h"
#include "CommonFramework/Logging/Logger.h"
#include "VideoFrameQt.h"
Expand Down
1 change: 0 additions & 1 deletion ...alPrograms/Source/CommonFramework/VideoPipeline/Backends/CameraWidgetQt6_QQuickWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <QByteArray>
#include <QUrl>
#include <QCamera>
#include <QPainter>
#include <QVideoSink>
#include <QQuickItem>
#include "Common/Qt/Redispatch.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/VideoPipeline/UI/VideoDisplayWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include <QLayout>
#include <QMainWindow>
#include <QResizeEvent>
#include "CommonFramework/GlobalAutoPaths.h"
Expand Down
2 changes: 0 additions & 2 deletions SerialPrograms/Source/CommonFramework/Windows/ButtonDiagram.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
*
*/

#include <QCoreApplication>
#include <QMessageBox>
#include <QMenuBar>
#include "CommonFramework/GlobalAutoPaths.h"
#include "WindowTracker.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonFramework/Windows/DpiScaler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include <QApplication>
#include <QScreen>
#include "DpiScaler.h"

Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonTools/ImageMatch/ImageMatchOption.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include "ImageMatchOption.h"

namespace PokemonAutomation{
namespace ImageMatch{
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonTools/Options/QtWidgets/ScreenWatchWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include <QDialog>
#include <QScreen>
#include <QMouseEvent>
#include <QApplication>
#include <QGuiApplication>
#include "CommonFramework/ImageTypes/ImageRGB32_Qt.h"
#include "CommonFramework/Tools/GlobalThreadPools.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonTools/Options/QtWidgets/StringSelectWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include <QStandardItemModel>
#include <QHBoxLayout>
#include <QLabel>
#include <QCompleter>
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/CommonTools/Options/ScreenWatchOption.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <QGuiApplication>
#include <QPixmap>
#include <QScreen>
#include <QWidget>
#include <QPainter>
#include "Common/Cpp/Containers/Pimpl.tpp"
#include "CommonFramework/Logging/Logger.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/ControllerInput/Keyboard/KeyboardInput_State.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include "KeyboardInput_State.h"

namespace PokemonAutomation{

Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/GameConsole/ConsoleHandle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include "Common/Cpp/Exceptions.h"
#include "Common/Cpp/Containers/Pimpl.tpp"
#include "CommonFramework/Tools/GlobalThreadPools.h"
#include "CommonFramework/VideoPipeline/VideoOverlay.h"
#include "CommonFramework/VideoPipeline/Stats/ThreadUtilizationStats.h"
#include "Controllers/NullController.h"
#include "Framework/ConsoleSystemSession.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/GameConsole/MultiConsoleProgram.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*/

#include "Common/Cpp/ScopeExit.h"
#include "CommonFramework/VideoPipeline/VideoOverlay.h"
#include "CommonFramework/VideoPipeline/Stats/ThreadUtilizationStats.h"
#include "CommonFramework/Panels/PanelSession.h"
#include "CommonFramework/Tools/GlobalThreadPools.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/GameConsole/Panels/GameConsole_SnapshotDumper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include <QKeyEvent>
#include "Common/Cpp/Exceptions.h"
#include "Common/Cpp/Filesystem/Filesystem.h"
#include "Common/Cpp/PrettyPrint.h"
Expand Down
1 change: 0 additions & 1 deletion ...s/ImageFilters/RGB32_EuclideanDistance/Kernels_ImageFilter_RGB32_Euclidean_ARM64_NEON.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include "Kernels/ImageFilters/Kernels_ImageFilter_Basic_Routines.h"
#include "Kernels/PartialWordAccess/Kernels_PartialWordAccess_arm64_NEON.h"
#include "Kernels/ImageFilters/Kernels_ImageFilter_Basic_Routines_ARM64_NEON.h"
#include "Kernels_ImageFilter_RGB32_Euclidean.h"

namespace PokemonAutomation{
namespace Kernels{
Expand Down
1 change: 0 additions & 1 deletion ...nels/ImageFilters/RGB32_EuclideanDistance/Kernels_ImageFilter_RGB32_Euclidean_Default.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include "Kernels/ImageFilters/Kernels_ImageFilter_Basic_Routines.h"
#include "Kernels/ImageFilters/Kernels_ImageFilter_Basic_Routines_Default.h"
#include "Kernels_ImageFilter_RGB32_Euclidean.h"

namespace PokemonAutomation{
namespace Kernels{
Expand Down
1 change: 0 additions & 1 deletion ...ms/Source/Kernels/ImageFilters/RGB32_Range/Kernels_ImageFilter_RGB32_Range_ARM64_NEON.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*/

#ifdef PA_AutoDispatch_arm64_20_M1
#include "Kernels/PartialWordAccess/Kernels_PartialWordAccess_arm64_NEON.h"
#include "Kernels/ImageFilters/Kernels_ImageFilter_Basic_Routines.h"
#include "Kernels/ImageFilters/Kernels_ImageFilter_Basic_Routines_ARM64_NEON.h"
#include "Kernels_ImageFilter_RGB32_Range_Routines.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/ML/Inference/ML_YOLONavigation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "CommonFramework/Exceptions/UnexpectedBattleException.h"
#include "CommonFramework/VideoPipeline/VideoFeed.h"
#include "CommonFramework/VideoPipeline/VideoOverlayScopes.h"
#include "CommonTools/Async/InferenceRoutines.h"
#include "ML/Inference/ML_YOLOv5Detector.h"
#include "ML/Models/ML_YOLOv5Model.h"
#include "NintendoSwitch/Commands/NintendoSwitch_Commands_PushButtons.h"
Expand Down
2 changes: 0 additions & 2 deletions SerialPrograms/Source/ML/Inference/ML_YOLOv5Detector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

#include <iostream>
#include <opencv2/imgproc.hpp>
#include <opencv2/imgcodecs.hpp>
#include <QMessageBox>
#include "Common/Cpp/Exceptions.h"
#include "Common/Cpp/PrettyPrint.h"
#include "Common/Cpp/Filesystem/Filesystem.h"
Expand Down
4 changes: 0 additions & 4 deletions SerialPrograms/Source/ML/Programs/ML_RunYOLO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@

//#include <iostream>
//#include <filesystem>
#include <opencv2/imgproc.hpp>
#include <opencv2/imgcodecs.hpp>
#include <QMessageBox>
//#include "Common/Cpp/PrettyPrint.h"
#include "CommonFramework/Globals.h"
#include "CommonFramework/GlobalAutoPaths.h"
#include "CommonTools/Async/InferenceRoutines.h"
//#include "CommonFramework/VideoPipeline/VideoOverlayScopes.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/NintendoSwitch/Controllers/Joycon/NintendoSwitch_Joycon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include "Common/Cpp/Containers/Pimpl.tpp"
#include "ControllerInput/ControllerInput.h"
#include "ControllerInput/Keyboard/KeyboardInput_State.h"
#include "Controllers/ControllerTypes.h"
#include "Controllers/RumbleListener.h"
#include "NintendoSwitch/NintendoSwitch_Settings.h"
#include "NintendoSwitch/Controllers/NintendoSwitch_VirtualControllerState.h"
Expand Down
1 change: 0 additions & 1 deletion SerialPrograms/Source/NintendoSwitch/Controllers/SysbotBase/SysbotBase_Connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*
*/

#include <QEventLoop>
#include "Common/Cpp/Time.h"
#include "Common/Cpp/ColoredText.h"
#include "CommonFramework/Logging/Logger.h"
Expand Down
Loading
Loading