Skip to content

FRLG Magikarp RNG: add button press for the Japanese version #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theastrogoth merged 1 commit into from
Oct 30, 2026
Merged

FRLG Magikarp RNG: add button press for the Japanese version #1769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ms/Source/VideoGames/PokemonFRLG/Programs/RngManipulation/PokemonFRLG_BlindNavigation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ static uint64_t magikarp_fixed_duration(Language language){
if (language == Language::French){
duration -= 1500;
}
if (language == Language::Japanese){
duration += 1500;
}
return duration;
}

Expand Down Expand Up @@ -184,6 +187,9 @@ void collect_magikarp_after_delay(ProControllerContext& context, uint64_t ingame
if (language != Language::French){
pbf_press_button(context, BUTTON_A, 200ms, 1300ms);
}
if (language == Language::Japanese){
pbf_press_button(context, BUTTON_A, 200ms, 1300ms);
}
pbf_press_button(context, BUTTON_A, 200ms, std::chrono::milliseconds(ingame_delay - magikarp_fixed_duration(language)));
// Finish dialogue (hits the target advance)
pbf_press_button(context, BUTTON_A, 200ms, 3800ms);
Expand Down
Loading